Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align asynchronous client according to the new design #708

Closed
6 of 11 tasks
Bhashinee opened this issue Dec 8, 2020 · 0 comments
Closed
6 of 11 tasks

Align asynchronous client according to the new design #708

Bhashinee opened this issue Dec 8, 2020 · 0 comments
Assignees
@Bhashinee
Labels
module/websocket Type/NewFeature Verson/SwanLakeDump All issues planned for Swan Lake GA release
Milestone
Swan Lake Alpha

Comments

@Bhashinee
Copy link
Member

Bhashinee commented Dec 8, 2020 •
edited
Loading

Spec: https://docs.google.com/document/d/112iUKhqqsC1-Z62myUS72RNIz1n7zybLJiJfsEQhdMw/edit?usp=sharing

Need to align websocket async client according to the new design mentioned in the spec.

  • Take the callback service in client init.
  • Rename pushText and pushBinary to writeTextMessage and writeBinaryMessage
  • Rename onBinary and onText to onBinaryMessage and onTextMessage
  • Remove readyOnConnect API
  • Change Client init method to return errors
  • Update BBEs

Post alpha

  • Failover implementation
  • Retry implementation
  • Cookie support
  • Add Auth support
  • Compiler plugin validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bhashinee Bhashinee

Labels
module/websocket Type/NewFeature Verson/SwanLakeDump All issues planned for Swan Lake GA release
Projects
None yet
Milestone
Swan Lake Alpha
Development

No branches or pull requests
1 participant
@Bhashinee