Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Countdown latch in Websocket implementation #1385

Closed
shafreenAnfar opened this issue May 20, 2021 · 1 comment
Closed

Remove the Countdown latch in Websocket implementation #1385

shafreenAnfar opened this issue May 20, 2021 · 1 comment
Assignees
@Bhashinee
Labels
module/websocket Priority/High Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@shafreenAnfar
Copy link
Contributor

Description:
Pointed code needs to be written in reactive way. Otherwise, this code could struggle running in constrained environments.

https://github.com/ballerina-platform/module-ballerina-websocket/blob/main/websocket-native/src/main/java/org/ballerinalang/net/websocket/WebSocketUtil.java#L271
This was referenced Jun 7, 2021
Closed
Merged
@Bhashinee
Copy link
Member

Fixed with the above PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bhashinee Bhashinee

Labels
module/websocket Priority/High Team/PCM Protocol connector packages related issues Type/Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shafreenAnfar @Bhashinee