-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement immediateStop in HTTP listener #1794
Implement immediateStop in HTTP listener #1794
Comments
In the implementation, as per the current design, we are using a shared boss and worker EventLoopGroups over all the listeners as well as clients. As per Netty documentation, in order to shut down a Netty application, you need to shut down the EventLoopGroup. As we have been sharing this eventloop group among other listeners and clients, it is not possible to shutdown it immediately. It is not possible to create eventloopgroups per listener as it can result in an issue similar to this. |
I think what we need to do is instead of sharing the EventLoop group, we should share the thread pool. It seems we can do that by sharing a thread executor pool. |
Once the suggestion was implemented(Share instead of EventLoop group), local build facing |
As the proper solution, closed the socket pipeline of the server channel initializer after sharing the Eventloop groups again. Sorted #2990 |
Description:
Currently, the listener's
immediateStop
method is not implemented. Need to do a feasibility study on this.The text was updated successfully, but these errors were encountered: