Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow init function in gRPC services by the compiler plugin #2617

Closed
BuddhiWathsala opened this issue Jan 24, 2022 · 4 comments · Fixed by ballerina-platform/module-ballerina-grpc#661
Assignees
Labels
module/grpc Points/0.5 Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@BuddhiWathsala
Copy link
Contributor

Description:
$title

@BuddhiWathsala BuddhiWathsala added Points/0.5 Type/Improvement module/grpc Team/PCM Protocol connector packages related issues labels Jan 24, 2022
@BuddhiWathsala BuddhiWathsala self-assigned this Jan 24, 2022
@BuddhiWathsala
Copy link
Contributor Author

Should we allow all the functions including init or only allow the init function? @daneshk @shafreenAnfar @dilanSachi WDYT?

@shafreenAnfar
Copy link
Contributor

AFAIU, services can have any type of functions ? @rdhananjaya any thoughts ?

@BuddhiWathsala
Copy link
Contributor Author

Yes, normal functions are allowed in services. Then, I think it is better to allow all the normal functions and remote methods. We can disallow only the resource methods since those are not usable in the gRPC context.

@rdhananjaya
Copy link
Member

If we disallow regular member functions, we are forcing the programmers to write large methods. I don't think that's a good thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/grpc Points/0.5 Team/PCM Protocol connector packages related issues Type/Improvement
Projects
None yet
3 participants