Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make descriptor const public in the generated stub file #3653

Closed
daneshk opened this issue Nov 15, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-grpc#1085
Closed

Make descriptor const public in the generated stub file #3653

daneshk opened this issue Nov 15, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-grpc#1085
Assignees
@dilanSachi
Labels
module/grpc Reason/Other None of the other reasons. Team/PCM Protocol connector packages related issues Type/Bug
Milestone
2201.3.0

Comments

@daneshk
Copy link
Member

daneshk commented Nov 15, 2022

Description:
$subject. Currently, this descriptor is not public. Hence it can only access within the module.
@daneshk daneshk added Type/Bug module/grpc Team/PCM Protocol connector packages related issues labels Nov 15, 2022
@dilanSachi dilanSachi mentioned this issue Nov 16, 2022
Merged
5 tasks
Repository owner moved this from PR Sent to Done in Ballerina Team Main Board Nov 16, 2022
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@dilanSachi dilanSachi added the Reason/Other None of the other reasons. label Nov 30, 2022
@dilanSachi dilanSachi added this to the 2201.3.0 milestone Nov 30, 2022
@madhukaw madhukaw mentioned this issue Jan 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilanSachi dilanSachi

Labels
module/grpc Reason/Other None of the other reasons. Team/PCM Protocol connector packages related issues Type/Bug
Projects
None yet
Milestone
2201.3.0
Development

Successfully merging a pull request may close this issue.

Make descriptor const public dilanSachi/module-ballerina-grpc
2 participants
@daneshk @dilanSachi