Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java dependencies have not been included with group id & artifact id in GRPC module #3789

Closed
NipunaMadhushan opened this issue Dec 6, 2022 · 3 comments · Fixed by ballerina-platform/module-ballerina-grpc#1107
Assignees
Labels
module/grpc Points/0.25 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Milestone

Comments

@NipunaMadhushan
Copy link

Description:
Java dependencies should be included with group id and artifact id in order to check the version of the same dependency in two modules and pick the latest version. Otherwise it will give a warning message about the conflict.

In grpc module, some dependencies have been included without group id & artifact id and it has been led to conflict warning messages.

https://github.com/ballerina-platform/module-ballerina-grpc/blob/master/ballerina/Ballerina.toml#L38

Steps to reproduce:

Affected Versions:

OS, DB, other environment details and versions:

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@dilanSachi
Copy link
Contributor

I was under the impressions this was needed only for Ballerina native jar dependencies.
This is the same way done in http as well.
https://github.com/ballerina-platform/module-ballerina-http/blob/master/ballerina/Ballerina.toml#L30

@dilanSachi
Copy link
Contributor

Had an offline discussion with @azinneera.

We need to update the libraries that has a chance to be used in other libraries. To be on the safe side, we can update all the dependencies.

@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@dilanSachi dilanSachi added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label Dec 21, 2022
@dilanSachi dilanSachi added this to the 2201.4.0 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/grpc Points/0.25 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants