Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gRPC] Bugs in streaming with Empty Type. #387

Closed
daksithj opened this issue Apr 20, 2020 · 1 comment · Fixed by ballerina-platform/ballerina-lang#22794 or ballerina-platform/module-ballerina-grpc#305
Assignees
Labels
module/grpc Priority/High Team/PCM Protocol connector packages related issues Type/Bug Verson/SwanLakeDump All issues planned for Swan Lake GA release

Comments

@daksithj
Copy link

There are some multiple bugs in streaming involving an Empty request or response.

  1. In server streaming, if the request message is of Empty type, the following error shows up in the client side.
    error {ballerina/grpc}InternalError message=Error while processing the request message. Connection Sub type not supported

  2. In client streaming, there is no way to send an Empty type response back to the client (neither caller->send() nor caller->complete() seems to do the job).

  3. When generating a service sample for streaming (--mode=service) with Empty requests, incorrect function parameters are generated as follows.
    resource function UnaryStream(grpc:Caller caller, value) {
    // Implementation goes here.
    }

  4. When generating a service sample for client streaming, the generated "name" field in the service config is incorrect. The resource name is generated here, whereas it should be the service name.
    @grpc:ServiceConfig {
    name: "service name should be generated instead here",
    clientStreaming: true
    }
    or else the following error shows up:
    error: {ballerina/grpc}InternalError message=Error when initializing service register builder. Couldn't find the service descriptor for the service: resourceName

@daneshk
Copy link
Member

daneshk commented Aug 18, 2020

Issue 03 and 04 are fixed in the master branch. We need to check issue 01 and 02.

@daneshk daneshk transferred this issue from ballerina-platform/ballerina-lang Oct 26, 2020
@daneshk daneshk added module/grpc Type/Bug Verson/SwanLakeDump All issues planned for Swan Lake GA release labels Oct 26, 2020
@anupama-pathirage anupama-pathirage added the Team/PCM Protocol connector packages related issues label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/grpc Priority/High Team/PCM Protocol connector packages related issues Type/Bug Verson/SwanLakeDump All issues planned for Swan Lake GA release
Projects
None yet
4 participants