Passing in a existing memcached client ignores the secret option

[danielb7390]

I have a project that already has a memcached instance created, yet when adding connect-memcached, it will create a new instance of the client but i wanted to use the existing instance

Took a look at the code and i see i can pass in a client at MemcachedStore(), but for some reason in case a client is passed the secret option is ignored:

connect-memcached/lib/connect-memcached.js

Lines 32 to 53 in 5116ea3

	function MemcachedStore(options) {
	options = options || {};
	Store.call(this, options);
	this.prefix = options.prefix || "";
	this.ttl = options.ttl;
	if (!options.client) {
	if (!options.hosts) {
	options.hosts = "127.0.0.1:11211";
	}
	if (options.secret) {
	(this.crypto = require("crypto")), (this.secret = options.secret);
	}
	if (options.algorithm) {
	this.algorithm = options.algorithm;
	}
	options.client = new Memcached(options.hosts, options);
	}
	this.client = options.client;
	}

Shouldn't the if (options.secret) block be outside the if (!options.client)?

[balor]

@danielb7390 Valid observation, the same applies to algorithm option. Luckily I'm planning to do some long due chores on this repository this week so I'll be able to include fix for mentioned quirk.

[balor]

FYI I'm planning to add your case as a test, for this purpose I've migrated test "suite" from manual scripts to Jest. Next steps in progress.

[danielb7390]

Thanks for the update!

[balor]

small update: working on merging this pr, which will also fix this issue along the way

[balor]

Version v2.0.0 should address this issue. In case you're using data encryption, remember to flush the session data before upgrading.