feat: ✨ Add danger and safe zone to charts #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AntoineThibi
commented
May 26, 2023
AntoineThibi
commented
✅ Deploy Preview for flashlight-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Flashlight Automated Report 🔦 |
Almouro
reviewed
May 26, 2023
| @@ -61,6 +61,9 @@ export const CPUReport = ({ | |||
| height={500} | |||
| interval={POLLING_INTERVAL} | |||
| series={totalCPUUsage} | |||
| annotationIntervalList={[ | |||
| { y: 180, y2: 1000, color: "red", label: "Danger Zone" }, | |||
There was a problem hiding this comment.
can we make those constants? to make sure the big useMemo containing the options doesn't rerender
Also color wise, can we use:
error: "#E62E2E",
success: "#158000"
We can hardcode tbh if we don't have a fast way to reuse the theme
| @@ -107,6 +137,7 @@ export const Chart = ({ | |||
| }, | |||
| annotations: { | |||
| xaxis: videoEnabled ? [getVideoCurrentTimeAnnotation()] : [], | |||
| yaxis: getAnnotationInterval(annotationIntervalList), | |||
There was a problem hiding this comment.
eslint is saying you need to add the annotationIntervalList to the array of deps
There was a problem hiding this comment.
The eslint config and prettier is a little weird isn't it ? It does the prettier only after the push...
| @@ -72,6 +100,7 @@ export const Chart = ({ | |||
| maxValue, | |||
| showLegendForSingleSeries, | |||
| colors = getColorPalette(), | |||
| annotationIntervalList = [], | |||
There was a problem hiding this comment.
same here, make it null by default to avoid recomputing the option below
AntoineThibi
force-pushed
the
Chart-Add-Zone
branch
from
2983b95
to
2bad774
Compare
Flashlight Automated Report 🔦 |
Flashlight Automated Report 🔦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.