Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static_pool_data.csv has the pair trimmed by a single character #393

Open
NIXBNT opened this issue Feb 23, 2024 · 0 comments
Open

static_pool_data.csv has the pair trimmed by a single character #393

NIXBNT opened this issue Feb 23, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@NIXBNT
Copy link
Collaborator

NIXBNT commented Feb 23, 2024

Bug Description

#391

  • Summary of the bug
    static_pool_data.csv seems to be being populated incorrectly. The pair_name and descr have the final character trimmed off
    Example:
0xB775272E537cc670C65DC852908aD47015244EaF,,4113078,pancakeswap_v3 0x4200000000000000000000000000000000000006/0x833589fCD6eDb6E08f4c7C32D4f71b54bdA0291 500,0x4200000000000000000000000000000000000006/0x833589fCD6eDb6E08f4c7C32D4f71b54bdA0291,pancakeswap_v3,500,0.0005,0xB775272E537cc670C65DC852908aD47015244EaF,,0x4200000000000000000000000000000000000006,0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913,18,6,4,WETH,USDC,0,0,0,0,0,0,10,pancakeswap_v3,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,

the pair should actually be

0x4200000000000000000000000000000000000006/0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913

Severity (High/Medium/Low)

  • Rate the severity. High: "I can't/won't use the bot due to this", Low: "I can work around it", Medium: (anything in between).
    Unclear

Steps to Reproduce

  • Step-by-step reproduction method, include environment information if relevant - such as Python version and OS.
    Produces itself

Expected Behavior

  • What should happen
    Unclear if this has flow on effects

Actual Behavior

  • What currently happens

Impact Analysis (to be filled by contributors)

  • Automated Tests: Are there existing tests covering this? Do we need new tests?
  • Risks: Potential areas affected by this bug and its probable fix
  • Performance: Is this bug affecting performance?
  • Monitoring: Does this affect any current monitoring? Any new alerts needed?
  • Logging: Any changes required in logging?
  • Documentation: Updates needed in documentation?
@NIXBNT NIXBNT added the bug Something isn't working label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants