You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
handle_target_token_addresses unnecessarily iterates over static pool data and in the process creates a new target token list that no longer contains the native token address. handle_target_token_addresses is a legacy method that was used to translate token-keys into token addresses. Since target_tokens are now specified as token addresses this process is both obsolete and incorrect since it can remove the native token address REQUIRED for example to fetch ETH containing strategies from Carbon (not just WETH).
Severity (High/Medium/Low)
Moderate. The user request is not adhered to resulting in data not collected for Carbon strats
Bug Description
handle_target_token_addresses
unnecessarily iterates over static pool data and in the process creates a new target token list that no longer contains the native token address.handle_target_token_addresses
is a legacy method that was used to translate token-keys into token addresses. Since target_tokens are now specified as token addresses this process is both obsolete and incorrect since it can remove the native token address REQUIRED for example to fetch ETH containing strategies from Carbon (not just WETH).Severity (High/Medium/Low)
Steps to Reproduce
Actual Behavior
Zero strategies fetched
2024-05-07 11:16:57,633 [fastlane:INFO] - Retrieved 313 carbon_v1 pairs from contract
2024-05-07 11:16:57,634 [fastlane:DEBUG] - Retrieving carbon_v1 strategies from contract
2024-05-07 11:16:58,303 [fastlane:DEBUG] - [events.managers.base] carbon_v1 is initialized True
2024-05-07 11:16:58,303 [fastlane:DEBUG] - [events.managers.base] Retrieved 0 carbon_v1 strategies
2024-05-07 11:16:58,303 [fastlane:DEBUG] - Fetched 0 carbon_v1 strategies in 6.899940252304077 seconds # ZERO STRATEGIES!
Expected Behavior
A subset of strategies fetched in the last step consistent with the target tokens
2024-05-07 11:39:12,884 [fastlane:INFO] - Retrieved 313 carbon_v1 pairs from contract
2024-05-07 11:39:12,884 [fastlane:DEBUG] - Retrieving carbon_v1 strategies from contract
2024-05-07 11:39:17,696 [fastlane:DEBUG] - [events.managers.base] carbon_v1 is initialized True
2024-05-07 11:39:17,696 [fastlane:DEBUG] - [events.managers.base] Retrieved 1 carbon_v1 strategies
2024-05-07 11:39:17,696 [fastlane:DEBUG] - Fetched 90 carbon_v1 strategies in 9.834237337112427 seconds
Impact Analysis (to be filled by contributors)
The text was updated successfully, but these errors were encountered: