Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Hasura prep command in flusher #2395

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Hasura prep command in flusher #2395

wants to merge 4 commits into from

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Aug 5, 2020

Fixed: #2389

Implementation details

Create hasura role with input password
Create schema
Grant access to new user
Track all tables/relation
Edit validator-account relation
Rename redelegation relation

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit and taobun August 5, 2020 10:45
@render
Copy link

render bot commented Aug 5, 2020

Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

engine.execute('''ALTER SCHEMA hdb_catalog OWNER TO hasura;''')
engine.execute('''ALTER SCHEMA hdb_views OWNER TO hasura;''')

# # grant select permissions on information_schema and pg_catalog. This is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need double comment

@@ -0,0 +1,52 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this empty line

@@ -125,7 +125,7 @@ services:
image: bandchain_flusher:latest
networks:
bandchain:
command: sh -c "sleep 30 && python main.py init bandchain test --db postgres:postgrespassword@172.18.0.88:5432/postgres"
command: sh -c "sleep 30 && python main.py init bandchain test --db postgres:postgrespassword@172.18.0.88:5432/postgres && python main.py hasura postgrespassword --db postgres:postgrespassword@172.18.0.88:5432/postgres"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want docker to use new user, please use the new user on hasura service too.

@taobun
Copy link
Member

taobun commented Oct 4, 2020

@Benzbeeb please resolve conflict and fix following comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hasura prep command in flusher
3 participants