Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape subshell commands #282

Merged
merged 3 commits into from
Sep 30, 2017
Merged

Escape subshell commands #282

merged 3 commits into from
Sep 30, 2017

Conversation

b-ryan
Copy link
Owner

@b-ryan b-ryan commented Sep 11, 2017

Maybe a viable fix for #264 ?

I couldn't find any workable solution using existing python code. Even shlex.quote didn't seem to work from my testing. Instead, this branch escapes backticks and the dollar sign.

Tests:

selection_005

Some thoughts:

  • This is only appropriate for bash & maybe zsh. I'm also not sure it's a sufficient change.

@b-ryan
Copy link
Owner Author

b-ryan commented Sep 30, 2017

I did some basic testing and this problem doesn't appear to affect either fish or zsh. So I modified my code to only apply itself to bash shells. Testing is going well. Going to merge this since it's better than letting the bug sit out there.

@b-ryan b-ryan merged commit bffc8af into b-ryan:master Sep 30, 2017
@b-ryan b-ryan deleted the fix-cmd-escape branch September 30, 2017 15:03
b-ryan pushed a commit that referenced this pull request Sep 30, 2017
@b-ryan b-ryan mentioned this pull request Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant