Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short path, long cwd #321

Merged
merged 3 commits into from
Nov 25, 2017
Merged

short path, long cwd #321

merged 3 commits into from
Nov 25, 2017

Conversation

jceaser
Copy link
Contributor

@jceaser jceaser commented Nov 5, 2017

This change will augment the cwd display to allow for the path to be shortened while keeping the last directory (cwd) long.

Change first discussed in issue #303 .

@b-ryan
Copy link
Owner

b-ryan commented Nov 6, 2017

hey @jceaser - thanks for the PR. This change is too complicated for such a small feature. It is too many options / too much code. I mentioned in #303 that I was leaning more toward a boolean option on whether to shorten the last directory and now feel more strongly that is what we should do.

@jceaser
Copy link
Contributor Author

jceaser commented Nov 6, 2017

ok, I'll rework this.

@jceaser
Copy link
Contributor Author

jceaser commented Nov 7, 2017

it's bool and 4 lines of code. How about now?

@jceaser
Copy link
Contributor Author

jceaser commented Nov 25, 2017

who reviews these pull requests?

@b-ryan
Copy link
Owner

b-ryan commented Nov 25, 2017

I do :) Just been rather busy lately. Thanks for the change!

@b-ryan b-ryan merged commit 2853cd8 into b-ryan:master Nov 25, 2017
@jceaser
Copy link
Contributor Author

jceaser commented Nov 25, 2017

please see #316 next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants