Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to fix the aspect ratio of the viewer? #26

Closed
charlie0129 opened this issue Apr 2, 2022 · 3 comments
Closed

Option to fix the aspect ratio of the viewer? #26

charlie0129 opened this issue Apr 2, 2022 · 3 comments

Comments

@charlie0129
Copy link

Just like the QuickTime Player, when you open a video, no matter how you resize the window, the aspect ratio stays the same.

It will be helpful if there is an option to toggle this functionality, since currently the viewer is freely resizable, leaving blank edges (if the aspect ratio of the viewer and iPhone screen is not the same). Although it is not a big deal, a simple resize would solve it. Fixing the viewer aspect ratio to the iPhone screen would be better.

Screen Shot 2022-04-02 at 7 34 01 PM

@banjun
Copy link
Owner

banjun commented Apr 7, 2022

@charlie0129 Sounds good. What do you think about PR #25 ? Is the option (= enable/disable the feature that fixes aspect ratio) required for your purpose?

@charlie0129
Copy link
Author

Yes, exactly. I compiled a version from that branch, and it worked well!

@banjun
Copy link
Owner

banjun commented Apr 8, 2022

thank you for your test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants