-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS-1: Acceptance Criteria for Diamond #1
Comments
That's a new one on me. Most people would say that SMILES does not support extended structures. I'd love to know any program that reads that as diamond. However, as a general point, it may be that I do not support the "&", so I'll leave this open until I've checked. |
Just checked the opensmiles.pdf you point to. This is in the "Proposed extensions" section, and so not part of Daylight SMILES. |
Ah huh, in the proposed section it looks like the reason why it wasn't implemented was because of the RDKit can process strings like What are your thoughts? |
Hello,
I was testing my dataset against different validation platforms and it seems like
C&1&1&1
is throwing a rejection. I added it to my list because it's defined in the openSMILES as diamond, Page 21.http://opensmiles.org/opensmiles.pdf
I'm wondering if this should be accepted by the partialSMILES?
`
The text was updated successfully, but these errors were encountered: