Fixes #201: Implements get approximate item count for dynamodb table #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: 2 new issues, 1 updated code elements |
JackPriceBurns
approved these changes
Feb 6, 2020
baopham
reviewed
Feb 7, 2020
| @@ -19,6 +19,7 @@ Supports all key types - primary hash key and composite keys. | |||
| * [find() and delete()](#find-and-delete) | |||
| * [Conditions](#conditions) | |||
| * [all() and first()](#all-and-first) | |||
| * [getItemCount()](#getItemCount) | |||
| * | ||
| * @return int | ||
| */ | ||
| public static function getItemCount() |
Comment on lines
+473
to
+476
| $describeTable = $model->getClient()->describeTable([ | ||
| 'TableName' => $model->getTable() | ||
| ]); | ||
| return $describeTable->get('Table')['ItemCount']; |
There was a problem hiding this comment.
I prefer that the query is actually done in the DynamoDbQueryBuilder. And that would allow us to do:
return $model->newQuery()->getTableItemCount();
baopham
requested changes
Feb 7, 2020
There was a problem hiding this comment.
Thanks for working on this!
We should never merge something that breaks the test. Not sure why travis is still running 7.1 though. @sahilsharma011 did you pull in the latest changes?
|
This PR has been stale for a over a year, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201