Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-extract the title/description at time of merge #78

Closed
pnkfelix opened this issue Apr 21, 2015 · 0 comments
Closed

Re-extract the title/description at time of merge #78

pnkfelix opened this issue Apr 21, 2015 · 0 comments

Comments

@pnkfelix
Copy link

Spawned off of #51.

Homu is smart enough to update PR title/descriptions in response to new comments that are added.

However, if someone edits the title/description but does not add a new comment, homu won't see the edit.

This means that important edits like "[breaking-change]" or "this needs to go in beta channel too" are sometimes left out of the final commit record, and thus there is no record of the note except in the original Pull Request.

It seems like it would not be too much overhead for Homu to do one final extraction of the PR title/description at the time it constructs the merge commit to be tested.

@barosl barosl closed this as completed in b47e311 Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant