Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add __version__ to PseudoNETCDF #128

Closed
mathause opened this issue Oct 18, 2021 · 4 comments
Closed

add __version__ to PseudoNETCDF #128

mathause opened this issue Oct 18, 2021 · 4 comments

Comments

@mathause
Copy link

mathause commented Oct 18, 2021

PseudoNETCDF currently does not have the conventional PseudoNetCDF.__version__ string. Would nice if this was added. It currently needs to be imported as:

from PseudoNetCDF import version

version.version

In addition, when installing pseudonetcdf with conda the version is also reported wrong - it reports '3.1.0.dev0+Unknown' (I am not sure if that has to be fixed here or in conda-forge/pseudonetcdf-feedstock.

The background is that the new release breaks an xarray test. This should be easily fixable but only if we get the correct version number.

@mathause
Copy link
Author

It's most likely possible to fix the xarray issue without the version number, see pydata/xarray#5875.

@barronh
Copy link
Owner

barronh commented Oct 18, 2021

Great point. I realized that the version number was not correctly updated in the release. I'll add a version import of version.version and release v3.2.1. Will that solve the problem?

@mathause
Copy link
Author

With pydata/xarray#5875 I could fix the issue without requiring the version number. But fixing this issue would nonetheless be appreciated!

You may want to do

import version.version as __version__

or

import version
__version__ = version.version

@barronh
Copy link
Owner

barronh commented Oct 18, 2021

I have made the change, but am waiting for the release due to Travis-CI. If I can't get the build to launch quickly, I'll release after manually testing on another platform.

@barronh barronh closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants