newQuery() is not static

[Jamesking56]

php artisan ide-helper:models --write adds query() and newQuery() as static methods in the PHPDoc of the model class.

query() is static, but newQuery() isn't. However, ide-helper marks them both as static.

This normally wouldn't matter too much, until you use strict PHPStan which states that any usages of newQuery() should be static. So $model->newQuery() fails PHPStan due to the false PHPDoc added by ide-helper.

I hope that makes sense, but basically newQuery() shouldn't be marked as static.

[jpickwell]

The Method class constructor treats all methods as static.

[Jamesking56]

Yes but it shouldn't do, since some methods aren't static.

[mfn]

I'd say: PRs welcome 😄

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

[barryvdh]

Closed in favor of #872

[mfn]

@barryvdh FTR this is closed in favour of a PR ( #872 ) but there's also a competing PR #897 and neither is merged so the reported issue per se isn't solved yet.

I don't want to override your closing but I think as long as it's not "done" we should keep it open?