Profiler shows a lot of CPU time spent in Spell Right

[borekb]

Hi, I'm trying extension profiler for the first time for unrelated reasons but when I turned on recording after a start of my VSCode, this was the result after about 20 seconds (can't remember exactly):

I only had a single Markdown file open at that time so this seems excessive. If you'd be interested in more performance reports, I'll be happy to gather them.

• Extension Name: spellright
• Extension Version: 2.5.32
• OS Version: Darwin x64 17.7.0
• VSCode version: 1.27.2

[bartosz-antosik]

1. Could you point me to some documentation/information on how to use profiler?
2. Could you share the document or choose some common document so that we can compare results etc.?

[borekb]

I'm very new to this myself, was advised here: microsoft/vscode#57697 (comment)

I'll try to reproduce it on a public repo we have; this one is private. My suspicion is that the problem is that it's a monorepo with many Markdown files and VSCode might be opening these files in the background even though it shouldn't (microsoft/vscode#50874). Need to play with it more.

[bartosz-antosik]

Hi! Do you have any new development around this issue?

[borekb]

Yes, it's reproducible on our public repo: just clone it locally and start VSCode on it.

[borekb]

(and sorry for the delay)

[bartosz-antosik]

Sorry, I cannot reproduce this. I have opened VSCode on the folder, displayed profiler - nothing really happens... Could you maybe tell which document(s) open to spell from this repository?

[bartosz-antosik]

I have randomly clicked few files here and there but it results in something like this:

[borekb]

Strange, I'm on a PC now (the previous screenshot was a Mac) and I can't reproduce either. This is my user settings BTW:

    "spellright.language": "en",
    "spellright.addToSystemDictionary": true,
    "spellright.notificationClass": "information",
    "spellright.documentTypes": [
        "markdown"
    ],
    "spellright.spellContext": "body comments strings",
    "spellright.spellContextByClass": {
        "markdown": "body",
        "typescript": "comments",
        "json": "comments",
        "html": "body",
        "typescriptreact": "body comments strings",
    },

Do you also get a lot of spelling issues in the Problems panel?

Note that I don't have any files open, only the Running Extensions tab. Maybe my other Markdown extensions are triggering processing MD files which includes spell checking? Again, that might be because of microsoft/vscode#50874.

[bartosz-antosik]

No, I have only active document diagnostics.

Have both these machines get same set of extensions?

[borekb]

It seems that it's related to the MarkDown Link Suggestions extension, with a recent comment here: microsoft/vscode#50874 (comment)

I think we're on a tangent now, maybe my initial issues were related to that. Sorry for a confusing issue, I feel it will be best to close it and if I ever spot anything suspicious regarding performance, I'll create a new one. Thanks for your cooperation!

[bartosz-antosik]

Absolutely, shall you have any new development let me know.

Maybe you could switch the problematic extension off for a test and see if it changes anything?

[borekb]

I did. On my PC (unlike on Mac), with both the problematic extension enabled and disabled, I could not reproduce the original report – Spell Right was never consuming too much CPU time. Strange things happen :)