Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Assigning Duplicate Ports #46

Merged

Conversation

sghoweri
Copy link
Contributor

Updates the Twig renderer to ensure that ports being checked to be available are using the same host as the PHP server + remember which ports have already been assigned to server instances to try and fix reoccurring errors like https://travis-ci.com/bolt-design-system/bolt/jobs/217386130#L690 from happening.

image

…rts + ensure available port checked uses the same host as the PHP server
@EvanLovely EvanLovely merged commit f922aa2 into knapsack-cloud:master Sep 6, 2019
github-actions bot pushed a commit that referenced this pull request Sep 6, 2019
## [0.12.1](v0.12.0...v0.12.1) (2019-09-06)

### Bug Fixes

* add higher php memory limit ([#51](#51)) ([237dc14](237dc14))
* ci update ([dfc8d90](dfc8d90))
* improved handling of already assigned ports ([#46](#46)) ([f922aa2](f922aa2))
* include types in module ([d908f5b](d908f5b))
@github-actions
Copy link

github-actions bot commented Sep 6, 2019

🎉 This PR is included in version 0.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants