Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit transactions need padding #133

Open
roninjin10 opened this issue Oct 6, 2023 · 0 comments
Open

Deposit transactions need padding #133

roninjin10 opened this issue Oct 6, 2023 · 0 comments
Labels
state: backlog This is pending further review type: enhancement New feature or request

Comments

@roninjin10
Copy link
Contributor

We need to estimate gas and add additional padding because without it the algorithm wallets use to estimate gas will often result in a failed tx.

The optimism sdk does this here: https://github.com/ethereum-optimism/optimism/blob/develop/packages/sdk/src/cross-chain-messenger.ts#L2028
@wbnns wbnns added state: backlog This is pending further review type: enhancement New feature or request labels Oct 6, 2023
@zencephalon zencephalon self-assigned this Oct 11, 2023
@zencephalon zencephalon removed their assignment Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: backlog This is pending further review type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbnns @zencephalon @roninjin10