Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: WalletConnect is broken on base.org #1531

Open
mrdomino opened this issue Jan 4, 2025 · 2 comments · May be fixed by #1532
Open

Bug: WalletConnect is broken on base.org #1531

mrdomino opened this issue Jan 4, 2025 · 2 comments · May be fixed by #1532
Labels
base web review To be reviewed by the Base web team

Comments

@mrdomino
Copy link

mrdomino commented Jan 4, 2025 •
edited
Loading

Describe the bug

After connecting to WalletConnect, there are JavaScript console errors and no connection.

Steps

  1. Go to base.org.
  2. Click "Connect."
  3. Click "WalletConnect" (or Rabby, which uses WalletConnect.)
  4. Click to show the WalletConnect modal, so that you can copy the URL.
  5. Paste it into either Rabby or BitBoxApp, approve connection, etc.
  6. Blue "Connect" button is replaced with a white-on-black "Connect to Base" button, the site otherwise does not change, and there are JS console errors about verify.walletconnect.com and verify.walletconnect.org being blocked by the Content-Security-Policy’s frame-src.

Expected behavior

I should be able to interact with Base from that wallet.

Additional info

Screenshot 2025-01-04 at 11 05 53 AM

Environment

  • OS: macOS Sequoia
  • Browser: Reproduced in Brave, Safari, and Chrome
  • Wallet: Rabby, BitBox02, Rainbow
@mrdomino mrdomino linked a pull request Jan 4, 2025 that will close this issue
Open
@mrdomino
Copy link
Author

mrdomino commented Jan 4, 2025

Just checked, it appears that Rainbow Wallet is also broken by this.

@base-org base-org deleted a comment Jan 9, 2025
@base-org base-org deleted a comment Jan 9, 2025
@wbnns wbnns added the base web review To be reviewed by the Base web team label Jan 9, 2025
@wbnns
Copy link
Member

wbnns commented Jan 9, 2025

@mrdomino

Heya! Thanks so much for opening this issue. Confirming this is in our backlog, pending to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add verify.walletconnect.org to frame-src mrdomino/base-web
2 participants
@mrdomino @wbnns