Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kamal app exec doesn't log in to docker #1163

Open
cromega opened this issue Oct 25, 2024 · 1 comment · May be fixed by #1227
Open

kamal app exec doesn't log in to docker #1163

cromega opened this issue Oct 25, 2024 · 1 comment · May be fixed by #1227

Comments

@cromega
Copy link

cromega commented Oct 25, 2024 •
edited
Loading

Kamal v2.2.2

Running kamal app exec to run migrations fails intermittently because kamal doesn't execute docker login on the remote host. In out case, the previously used ECR token expires at some point so depending on when the previous pipeline run was triggered, the next app exec may fail.

$ kamal app exec --version v1.2.3 --roles web --primary -d qa rails db:migrate
Launching command with version v1.2.3 from new container...
Running the pre-connect hook...
  INFO [4b63d86e] Running /usr/bin/env .kamal/hooks/pre-connect on localhost
  INFO [4b63d86e] Finished in 2.857 seconds with exit status 0 (successful).
  INFO [b2bca27f] Running docker run --rm --network kamal --env SERVICE="web" ... x.dkr.ecr.eu-central-1.amazonaws.com/image:v1.2.3
  ERROR (SSHKit::Command::Failed): Exception while executing on host x.x.x.x: docker exit status: 125
docker stdout: Nothing written
docker stderr: Unable to find image 'x.dkr.ecr.eu-central-1.amazonaws.com/image:v1.2.3' locally
docker: Error response from daemon: pull access denied for x.dkr.ecr.eu-central-1.amazonaws.com/image, repository does not exist or may require 'docker login': denied: Your authorization token has expired. Reauthenticate and try again.
See 'docker run --help'.

Compare it with kamal deploy:

$ kamal deploy -P --version v1.2.3 -d qa
Log into image registry...
Running the pre-connect hook...
  INFO [cd18ce5e] Running /usr/bin/env .kamal/hooks/pre-connect on localhost
  INFO [cd18ce5e] Finished in 3.591 seconds with exit status 0 (successful).
  INFO [4631cfff] Running docker login x.dkr.ecr.eu-central-1.amazonaws.com -u [REDACTED] -p [REDACTED] on x
  INFO [4631cfff] Finished in 9.694 seconds with exit status 0 (successful).
...
@cromega
Copy link
Author

cromega commented Oct 29, 2024

Can be easily worked around by running kamal registry login -d ... before app exec.

@andrewjanssen andrewjanssen linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kamal app exec may fail if not logged in menloparking/kamal
1 participant
@cromega