-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 #21
Milestone
Comments
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this crate is basically stable modulo minor improvements.
However before releasing 1.0 I'd like to re-review the API and maybe ask @janhohenheim if he has any input.
It might also make sense to wait for windows support to be released into the wild and for bat to ship terminal-colorsaurus. Maybe there's some feedback that we need to incorporate?
A couple of things that I already noticed:
ColorScheme
has a default impl (is that a good idea?)QueryOptions::default
(maybe I should change the default functions to take no params and have separatefunc_with(QueryOptions)
overloads?)#[non_exhaustive]
really needed onColorPalette
-> keeping it for nowis_terminal
check themselves which means every function gets a big "caveats" section. Is this the best option?UnsupportedTerminal
but for that I probably want aUnsupportedTerminalError
with private fields for now so I don't have to commit to a repr.ColorScheme
have aDisplay
impl? -> I don't think there's a single canonical representation for it, let's not add it.In most cases the answer is "no".
The text was updated successfully, but these errors were encountered: