You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this crate is basically stable modulo minor improvements.
However before releasing 1.0 I'd like to re-review the API and maybe ask @janhohenheim if he has any input.
It might also make sense to wait for windows support to be released into the wild and for bat to ship terminal-colorsaurus. Maybe there's some feedback that we need to incorporate?
A couple of things that I already noticed:
ColorScheme has a default impl (is that a good idea?)
everyone has to pass QueryOptions::default (maybe I should change the default functions to take no params and have separate func_with(QueryOptions) overloads?)
Is #[non_exhaustive] really needed on ColorPalette -> keeping it for now
Currently every consumer has to do the is_terminal check themselves which means every function gets a big "caveats" section. Is this the best option?
Maybe moving the caveats section to the crate docs might be good.
Would be fixed by c953b9f without a breaking change.
Raise MSRV? (Check where bat and delta are packaged and check what rust version these distros have)
It'd be nice to add additional information to UnsupportedTerminal but for that I probably want a UnsupportedTerminalError with private fields for now so I don't have to commit to a repr.
Should ColorScheme have a Display impl? -> I don't think there's a single canonical representation for it, let's not add it.
Is it really necessary to query both bg and fg color for the color scheme? How bad is the perf impact on slow terminals?
* If not, remove ColorPalettte.
I should also revise the crate docs a bit. Most notably I want to add a section "Should I try to detect the terminals theme?".
In most cases the answer is "no".
Moving the crate comparison to a docs module might also make sense, the crate-level docs are currently very crowded.
I think this crate is basically stable modulo minor improvements.
However before releasing 1.0 I'd like to re-review the API and maybe ask @janhohenheim if he has any input.
It might also make sense to wait for windows support to be released into the wild and for bat to ship terminal-colorsaurus. Maybe there's some feedback that we need to incorporate?
A couple of things that I already noticed:
ColorScheme
has a default impl (is that a good idea?)QueryOptions::default
(maybe I should change the default functions to take no params and have separatefunc_with(QueryOptions)
overloads?)#[non_exhaustive]
really needed onColorPalette
-> keeping it for nowis_terminal
check themselves which means every function gets a big "caveats" section. Is this the best option?UnsupportedTerminal
but for that I probably want aUnsupportedTerminalError
with private fields for now so I don't have to commit to a repr.ColorScheme
have aDisplay
impl? -> I don't think there's a single canonical representation for it, let's not add it.* If not, remove
ColorPalettte
.In most cases the answer is "no".
Color
with a new field for alpha.Color
's fields to full words (r -> red, ...)query
modThe text was updated successfully, but these errors were encountered: