c_src/eleveldb.cc:652]: (error) Memory leak: batch [JIRA: RIAK-2734]

[dcb314]

Source code is

// Construct a write batch:
leveldb::WriteBatch* batch = new leveldb::WriteBatch;

// Seed the batch's data:
ERL_NIF_TERM result = fold(env, argv[2], write_batch_item, *batch);
if(eleveldb::ATOM_OK != result)
{
    return send_reply(env, caller_ref,
                      enif_make_tuple3(env, eleveldb::ATOM_ERROR, caller_ref,
                                       enif_make_tuple2(env, eleveldb::ATOM_BAD_WRITE_ACTION,
                                                        result)));
}   // if

[matthewvon]

Agreed.

[larshesel]

The leak would be due to batch never being freed?

[matthewvon]

No clue why this was never closed. Fix is present in code. See

d595ae3

Batch is now freed in error handling.

[larshesel]

oh, cool - I hadn't seen that, only checked this bug was present in our version. Thanks!