Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snappy support is broken #275

Open
benjoe87 opened this issue Jul 7, 2023 · 0 comments
Open

Snappy support is broken #275

benjoe87 opened this issue Jul 7, 2023 · 0 comments

Comments

@benjoe87
Copy link

benjoe87 commented Jul 7, 2023

Snappy support is broken since 6ef9202.

The root cause seems like:

  1. The build flags are not exported in the Makefile
  2. The leveldb build cannot detect the snappy support and don't set the SNAPPY C marco https://github.com/basho/leveldb/blob/develop/build_detect_platform#L169
  3. The leveldb part is builded without snappy support.

It is hard to detect this issue during the tests because leveldb simply do not compress the blocks if snappy support is not present.
https://github.com/basho/leveldb/blob/b91d5cee860bc708c10c48911586fdb347558ea3/table/table_builder.cc#L212

But it definitely breaks the upgrades mentioned in #273

Exporting these variables probably solves the issue but I am not 100% sure that this is a comprehensive solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant