-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail version 3+ compatibility #17
Comments
please do |
On second thoughts, trying to maintain compatibility with wagtail versions before 3.0 looks too hard. The trouble is the changes to module paths (https://docs.wagtail.org/en/stable/releases/3.0.html#changes-to-module-paths) in Wagtail 3.0. I started amending from wagtail import VERSION
if VERSION[0] >= 3:
from wagtail.admin.panels import FieldPanel as SearchImagePanel
from wagtail.models import Site
else:
from wagtail.core.models import Site
from wagtail.images.edit_handlers import ImageChooserPanel as SearchImagePanel And then using However, there are many more locations where changes like that are needed. For example, in if VERSION[0] >= 3:
wagtail_app_str = "wagtail"
else:
wagtail_app_str = "wagtail.core" so that I could use that But then I encountered the So I now propose to increase the minimum Wagtail version to 3.0. Users with older wagtail version will need to continue using a version 2 of this package. |
The package is currently limited to wagtail version >1.4 and <3.0. All of those versions are out of support: https://github.com/wagtail/wagtail/wiki/Release-schedule.
I propose to submit a PR that will:
panels
in theMetadataPageMixin
so it will continue to work with Wagtail versions 3+;I think we could also drop support for Python 3.6, and add support for more recent Python versions.
I propose deploying the changes as a new version 3.0, because it will have breaking changes.
The text was updated successfully, but these errors were encountered: