Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This link should be broken or not? #10

Open
ff6347 opened this issue Dec 11, 2018 · 4 comments
Open

This link should be broken or not? #10

ff6347 opened this issue Dec 11, 2018 · 4 comments

Comments

@ff6347
Copy link
Member

ff6347 commented Dec 11, 2018

var loadedArray = b.loadStrings("https://raw.github.com/basiljs/basil.js/master/examples/demos/B08_bar_chart_from_csv_data/data/LA_Pools-Pools_per_Hood.csv");

@trych
Copy link
Contributor

trych commented Dec 11, 2018

Yes. This is fixed already in the develop branch:
See here

@ff6347
Copy link
Member Author

ff6347 commented Dec 11, 2018

Cool. In the tutorials this is also broken (see basiljs/basiljs.github.io#69) https://github.com/basiljs/basiljs.github.io/blob/develop/tutorials/12-data-csv/index.md#preparations points to https://github.com/basiljs/basil.js/blob/master/examples/demos/B08_bar_chart_from_csv_data/data/LA_Pools-Pools_per_Hood.csv

I'm wondering the link you have there is pointing to the master branch of the main basiljs repo. But the source for the exampels is located in this repo?

@ff6347
Copy link
Member Author

ff6347 commented Dec 11, 2018

Once we merge develop into master this will be broken again.

@trych
Copy link
Contributor

trych commented Dec 11, 2018

Haha, true. Hm, we probably should set up a folder in the examples repo itself, where we keep these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants