Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Icons not showing on buttons on Android #87

Closed
chrisfoulds opened this issue Dec 14, 2020 · 9 comments
Closed

[Bug] Icons not showing on buttons on Android #87

chrisfoulds opened this issue Dec 14, 2020 · 9 comments

Comments

@chrisfoulds
Copy link

Description

On the latest version of the library on Android the icons on the buttons are no longer working.

Steps to Reproduce

This works and shows icons on both platforms

                <Image HeightRequest="35" Margin="10,6,6,0"  VerticalOptions="CenterAndExpand" Grid.Row="0" Grid.Column="0">
                    <Image.Source>
                        <FontImageSource
                                FontFamily="{DynamicResource FontAwesomeRegular}"
                                Glyph="{StaticResource LeftArrow}"
                                Size="44"
                                Color="White" />
                    </Image.Source>
                </Image>

This however only works on iOS <f9p:Button VerticalOptions="CenterAndExpand" Clicked="Faster_Clicked" Text="Faster Times" IconText="{StaticResource TachFast}" IconFontFamily="{DynamicResource FontAwesomeRegular}" BackgroundColor="{StaticResource OrangeButton}" HasTightSpacing="True" TrailingIcon="False" ElementShape="Obround" HasShadow="True" HorizontalTextAlignment="Center" Spacing="35" Margin="5" FontSize="14" FontFamily="{DynamicResource RobotoBold}" TextColor="White"/>

Expected Behavior

Works the same as iOS

Actual Behavior

Blank icons

Basic Information

Latest forms & forms9patch

Screenshots

Screenshot_20201214-140049
IMG_2427

@baskren
Copy link
Owner

baskren commented Dec 15, 2020

Please send a demo project that replicates this issue.

@baskren
Copy link
Owner

baskren commented Dec 15, 2020

Yeah, definitely send me a demo project. It's not clear to me you're touching Forms9Patch with the sample XAML you've shared nor is it clear that this is within the scope of Forms9Patch.

@chrisfoulds
Copy link
Author

Sure attaching along with screenshots showing the button not working on droid

@chrisfoulds
Copy link
Author

Screenshot_1608117081
Simulator Screen Shot - iPhone SE (2nd generation) - 2020-12-16 at 11 07 28

@chrisfoulds
Copy link
Author

demoproblem.zip

@baskren
Copy link
Owner

baskren commented Dec 16, 2020

please verify fix with version 2.4.9-beta2

@chrisfoulds
Copy link
Author

Yep that works - thanks

@chrisfoulds
Copy link
Author

[
Screenshot 2020-12-16 at 14 54 32
]

@baskren baskren closed this as completed Dec 16, 2020
@baskren
Copy link
Owner

baskren commented Dec 16, 2020

Thank you for taking the time to verify this. v2.4.9 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants