Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatched arch session-manager-plugin got bundled #97

Closed
chenrui333 opened this issue Apr 29, 2024 · 7 comments
Closed

mismatched arch session-manager-plugin got bundled #97

chenrui333 opened this issue Apr 29, 2024 · 7 comments

Comments

@chenrui333
Copy link
Contributor

While packaging for homebrew, I noticed that the wrong arch session-manager-plugin got bundled (below is npm build for a apple arm machine):

Warning: Binaries built for a non-native architecture were installed into basti's prefix.
The offending files are:
  /opt/homebrew/Cellar/basti/1.6.2/libexec/lib/node_modules/basti/node_modules/basti-session-manager-binary-darwin-arm64/session-manager-plugin	(x86_64)
@BohdanPetryshyn
Copy link
Collaborator

BohdanPetryshyn commented Apr 30, 2024

Looks like the session-manager-plugin version used (1.2.295.0) doesn't output binaries for the darwin_arm architecture during the build so Basti uses darwin_amd64 instead. Here's the list of build outputs:

image

I'll take a look if a new version of the plugin supports darwin_arm this week. Meanwhile, I have a couple of questions:
  1. Is this issue blocking the Brew formula release?
  2. Maybe another binary from the screenshot above can be used for darwin_arm?

@BohdanPetryshyn
Copy link
Collaborator

I replied in the Homebrew PR. Looks like the plugin doesn't support arm architecture natively and amd64 works well with arm Macs.

@chenrui333
Copy link
Contributor Author

if you can point me the source, I can probably try to do some native source build with it.

@BohdanPetryshyn
Copy link
Collaborator

That would be great! Here's the repo: https://github.com/aws/session-manager-plugin

Please, also be aware of this issue: aws/session-manager-plugin#57. If possible, I'd recommend using the exact version used right now (1.2.295.0) since it looks like the later versions still have the problem discussed in the issue.

@chenrui333
Copy link
Contributor Author

since it looks like the later versions still have the problem discussed in the issue.

is it the same issue with the newer version?

@BohdanPetryshyn
Copy link
Collaborator

Unfortunately, I won't be able to test this right now but the same issue was reported again a month ago (aws/session-manager-plugin#93) and people are reporting the same issues in comments (aws/session-manager-plugin#57 (comment), aws/session-manager-plugin#93 (comment)).

@BohdanPetryshyn
Copy link
Collaborator

I'm closing this issue due to inactivity. Brew formula was successfully implemented without fixing this.

@BohdanPetryshyn BohdanPetryshyn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants