Replace travis with GitHub Actions workflow #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! 😍 I’ll take a look at this later. Is the docker buildx action by CrazyMax stable? What happens if they doesn’t maintain it any more? |
|
If CrazyMax deletes his action we need to find a new one or use a fork. But 139 stars for an action is much so I don't think it will disappear. |
|
I will update this PR to use the official docker actions https://github.com/crazy-max/ghaction-docker-buildx#moved-to-docker-organization |
updated docker-entrypoint.sh permissions in git added DOCKER_CLI_EXPERIMENTAL=enabled removed travis.yml
Legion2
force-pushed
the
docker-workflow
branch
from
bfe7fb4
to
6a0daa1
Compare
|
Travis.org is shutting down, so this project must be migrated to travis.com or switch to github actions. |
klaernie
added a commit
to klaernie/docker-MagicMirror
that referenced
this pull request
Jan 7, 2022
prep for actually building in github actions, thanks to the fine work by @Legion2 in bastilimbach#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create docker.yml workflow and removed travis.yml close #43
Also updated docker-entrypoint.sh permissions in git
@bastilimbach setup
DOCKER_USERNAMEandDOCKER_PASSWORDin the Settings > SecretsThe images are build on push and pull request on any branch. The images a only pushed from the master branch. The workflow is also triggered by cron on the master branch every day at 3:17 UTC.
The workflow uses the docker-buildx action by CrazyMax
I did not test the push to docker hub but only the build operation.