Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to use main thread parameters even during parallel processing #121

Closed
myConsciousness opened this issue Apr 10, 2022 · 0 comments · Fixed by #124
Closed

Should be able to use main thread parameters even during parallel processing #121

myConsciousness opened this issue Apr 10, 2022 · 0 comments · Fixed by #124
Assignees
@myConsciousness
Labels
Feedback: feature request I have a good idea Type: design

Comments

@myConsciousness
Copy link
Owner

1. Problem to solve

Should be able to use main thread parameters even during parallel processing.

2. Proposal

The async_task package has a mechanism for passing parameters of the main thread to parallel processing, so we will examine the feasibility of using this mechanism.

3. More information
@myConsciousness myConsciousness self-assigned this Apr 10, 2022
myConsciousness added a commit that referenced this issue Apr 11, 2022
@myConsciousness
fix: fix for the issue (#121)
16676f3
@myConsciousness myConsciousness linked a pull request Apr 11, 2022 that will close this issue
fix: fix for the issue (#121) #124
Merged
7 tasks
myConsciousness added a commit that referenced this issue Apr 11, 2022
@myConsciousness
fix: fixed for the issue (#121)
a49d185
myConsciousness added a commit that referenced this issue Apr 11, 2022
@myConsciousness
fix: fixed for the issue (#121)
6e798a7
bors bot added a commit that referenced this issue Apr 11, 2022
@bors @myConsciousness
Merge #124
10bc434 
124: fix: fix for the issue (#121) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require batch.dart users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [x] Yes, this is a breaking change.
- [ ] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/batch-dart/batch.dart/issues
[contributor guide]: https://github.com/batch-dart/batch.dart/blob/main/CONTRIBUTING.md
[batch.dart style guide]: https://github.com/batch-dart/batch.dart/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <kato.shinya.dev@gmail.com>
Co-authored-by: Kato Shinya <kato.shinya.dev@gmail.com>
myConsciousness added a commit that referenced this issue Apr 11, 2022
@myConsciousness
fix: fixed for the issue (#121)
840d3c4
bors bot added a commit that referenced this issue Apr 11, 2022
@bors @myConsciousness
Merge #124
142fed1 
124: fix: fix for the issue (#121) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require batch.dart users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [x] Yes, this is a breaking change.
- [ ] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/batch-dart/batch.dart/issues
[contributor guide]: https://github.com/batch-dart/batch.dart/blob/main/CONTRIBUTING.md
[batch.dart style guide]: https://github.com/batch-dart/batch.dart/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <kato.shinya.dev@gmail.com>
Co-authored-by: Kato Shinya <kato.shinya.dev@gmail.com>
@bors bors bot closed this as completed in #124 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
Feedback: feature request I have a good idea Type: design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix for the issue (#121) myConsciousness/batch.dart
1 participant
@myConsciousness