You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we are installing reqwest solely to talk to the Strapi backend, while also needing hyper for hosting the bot API server. After the recent dependency update, we are also explicitly relying on hyper-tls to talk to the Matrix servers via Ruma over https.
Since hyper should provide similar client functionality to reqwest, could we just replace the reqwest dependency with it and rewrite the Strapi module, @badboy ?
I looked into this yesterday because reqwest was pulling in a pre-1.x version of tokio, but felt way over my paygrade, and the reqwest package bump solved the issue, updating to a fully 1.x tokio stack, but it would still be useful to get rid of a (redundant) dependency if we could.
Fwiw I'm happy to look into this and give this a go if there is no particular show-stoppers why I shouldn't. :)
The text was updated successfully, but these errors were encountered:
Why? reqwest makes it very convenient to do HTTP requests. It's really the nice API on top of hyper that you want anyway, and removing that just makes you write all this code yourself (well, maybe "less code" but I still wouldn't bother)
Currently we are installing
reqwest
solely to talk to the Strapi backend, while also needinghyper
for hosting the bot API server. After the recent dependency update, we are also explicitly relying onhyper-tls
to talk to the Matrix servers via Ruma over https.Since
hyper
should provide similar client functionality toreqwest
, could we just replace thereqwest
dependency with it and rewrite the Strapi module, @badboy ?I looked into this yesterday because reqwest was pulling in a pre-1.x version of tokio, but felt way over my paygrade, and the reqwest package bump solved the issue, updating to a fully 1.x tokio stack, but it would still be useful to get rid of a (redundant) dependency if we could.
Fwiw I'm happy to look into this and give this a go if there is no particular show-stoppers why I shouldn't. :)
The text was updated successfully, but these errors were encountered: