Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.4.5 - Method definition #96

Open
mmeurisse-nacon opened this issue Sep 2, 2022 · 1 comment
Open

Magento 2.4.5 - Method definition #96

mmeurisse-nacon opened this issue Sep 2, 2022 · 1 comment

Comments

@mmeurisse-nacon
Copy link

Hello,

We need an update to let a 2.4.5 migration.

Error :
PHP Fatal error: Declaration of Bazaarvoice\Connector\Logger\Logger::addRecord($level, $message, array $context = []): bool must be compatible with Monolog\Logger::addRecord(int $level, string $message, array $context = [], ?Monolog\DateTimeImmutable $datetime = null): bool in /vendor/bazaarvoice/bazaarvoice-magento2-ext/Logger/Logger.php on line 77

Fix :
Add a use of Monolog\DateTimeImmutable;

And update addRecord definition

public function addRecord(int $level, string $message, array $context = [], DateTimeImmutable $datetime = null): bool

@khnaim
Copy link

khnaim commented Sep 12, 2022

Hello,
I have the same issue on :
-Magento 2.4.5 (ECE)
-bazaarvoice/bazaarvoice-magento2-ext : 9.1.4

have you been able to advance on the subject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants