Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: TODO(2.0) #198

Closed
7 tasks done
gregmagolan opened this issue Jul 28, 2022 · 2 comments
Closed
7 tasks done

Tracking issue: TODO(2.0) #198

gregmagolan opened this issue Jul 28, 2022 · 2 comments
Labels
tracking issue This is a tracking issue
Milestone
2.0

Comments

@gregmagolan
Copy link
Collaborator

gregmagolan commented Jul 28, 2022 •
edited by alexeagle
Loading

  • remove the override_local_config_platform attribute entirely
  • remove deprecated & unused is_windows parameter
  • remove deprecated exclude_prefix from copy_to_directory refactor: remove exclude_prefixes from copy_to_directory and copy_to_directory_bin_action #591
  • remove the legacy copy_to_directory_action helper
  • remove output_dir in expand_variables
  • what to do with the "Always register toolchains" bits for WORKSPACE users?
  • remove local_config_platform rule (principled fix landed in Bazel 6 so this is no longer needed)

Some of the above items can be located by searching for "TODO(2.0)" in the sources
@gregmagolan gregmagolan added this to the 2.0 milestone Jul 28, 2022
@gregmagolan gregmagolan changed the title Remove deprecated exclude_prefix from copy_to_directory (for next major release) Tracking issue: TODO(2.0) Jan 14, 2023
@gregmagolan gregmagolan added the tracking issue This is a tracking issue label Feb 6, 2023
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 6, 2023
@thesayyn
Copy link
Collaborator

note: we should also rename expand_make_vars into expand as it includes more than make vars now that expand_template supports stamping.

@alexeagle
Copy link
Collaborator

#593 for toolchain registration

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Open Source Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tracking issue This is a tracking issue
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@alexeagle @cgrindel @gregmagolan @thesayyn