Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: performance slower by default on copy actions #528

Closed
alexeagle opened this issue Sep 18, 2023 · 1 comment
Closed

[Bug]: performance slower by default on copy actions #528

alexeagle opened this issue Sep 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Collaborator

What happened?

Some users needed #506
but others liked it how it was, because it guaranteed better performance.

Maybe for 2.0 we should just admit that neither is a good default for everyone, and the setting is hard to discover, so we force users to put some flag in their bazelrc to opt-in to one behavior or the other (like we did with rules_ts 2.0)

Version

HEAD

How to reproduce

No response

Any other information?

No response
@alexeagle alexeagle added the bug Something isn't working label Sep 18, 2023
@alexeagle alexeagle added this to the 2.0 milestone Sep 18, 2023
@github-actions github-actions bot added the untriaged Requires traige label Sep 18, 2023
@alexeagle alexeagle removed the untriaged Requires traige label Oct 5, 2023
@alexeagle alexeagle removed this from the 2.0 milestone Oct 6, 2023
@alexeagle
Copy link
Collaborator Author

Fixed with #606

@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Oct 10, 2023
@alexeagle alexeagle mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeagle