Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: instructions to register jq toolchain in MODULE.bazel #592

Closed
pdeva opened this issue Oct 6, 2023 · 1 comment
Closed

[FR]: instructions to register jq toolchain in MODULE.bazel #592

pdeva opened this issue Oct 6, 2023 · 1 comment
Labels
enhancement New feature or request untriaged Requires traige

Comments

@pdeva
Copy link

pdeva commented Oct 6, 2023

What is the current behavior?

the release page only shows examples of registering jq toolchain with workspace file.

Describe the feature

currently no such instructions exist
@pdeva pdeva added the enhancement New feature or request label Oct 6, 2023
@github-actions github-actions bot added the untriaged Requires traige label Oct 6, 2023
@alexeagle
Copy link
Collaborator

There are no such instructions because there's nothing to do, our MODULE.bazel file already registers jq_toolchain for you.

See #597 for some related refactoring, but this will still be true.

We should probably add a sentence in the install section there about the toolchains being registered by default.

@alexeagle alexeagle mentioned this issue Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged Requires traige
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @pdeva