Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pre-factors for fix in copy_to_directory #858

Merged
merged 1 commit into from
May 28, 2024
Merged

refactor: pre-factors for fix in copy_to_directory #858

merged 1 commit into from
May 28, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented May 28, 2024 •
edited
Loading

Pre-factors for #857.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

CI

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented May 28, 2024 •
edited
Loading

Test

All tests were cache hits

215 tests (100.0%) were fully cached saving 44s.

Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.

Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 423ms.

Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Buildifier      Format      Gazelle

@gregmagolan gregmagolan marked this pull request as ready for review May 28, 2024 11:13
@gregmagolan gregmagolan mentioned this pull request May 28, 2024
Merged
@gregmagolan gregmagolan merged commit f30debb into main May 28, 2024
59 checks passed
@gregmagolan gregmagolan deleted the copy_to_directory_fixes_2 branch May 28, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @jbedard @kormide