Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stamping the version information in a variable. #54

Closed
thesayyn opened this issue Sep 24, 2023 · 1 comment
Closed

Allow stamping the version information in a variable. #54

thesayyn opened this issue Sep 24, 2023 · 1 comment
Assignees
@kormide
Labels
enhancement New feature or request

Comments

@thesayyn
Copy link

Currently, publish to bcr supports stamping only module(version = "0.0.0") which is very limiting if one wants to run custom logic based on the stamped version information.

https://bazelbuild.slack.com/archives/C014RARENH0/p1695424156083039
@thesayyn thesayyn mentioned this issue Sep 24, 2023
Merged
@kormide kormide self-assigned this Sep 25, 2023
@kormide kormide added the enhancement New feature or request label Sep 25, 2023
@kormide
Copy link
Collaborator

kormide commented Oct 23, 2023

As we discussed offline, a better solution to the problem was to support adding custom patches in a bcr entry. This was addressed as part of #49. Closing.

@kormide kormide closed this as completed Oct 23, 2023
@brentleyjones brentleyjones closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kormide kormide

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brentleyjones @kormide @thesayyn