Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bzlmod: maven.install repositories has silent last-wins semantics #1201

Open
plobsing opened this issue Jul 20, 2024 · 0 comments
Open

Bzlmod: maven.install repositories has silent last-wins semantics #1201

plobsing opened this issue Jul 20, 2024 · 0 comments

Comments

@plobsing
Copy link
Contributor

When the main module invokes maven.install more than once, the last invocation's value for repositories is what gets used. This includes the implicit repositories = [DEFAULT_REPOSITORIES] when the last call does not specify an explicit value for the argument.

This seems like an API design question. Maybe we do want to support multiple invocations and apply some kind of merge semantics to the repositories argument. Or maybe we want to support multiple invocations, but only one can have a repositories argument and that's what gets used (and there should be an error if there's more than one). Or maybe we don't support more than one invocation, in which case calling maven.install multiple times should be an error. I don't think the current behaviour of letting the user call maven.install multiple times, but silently ignoring some of their explicit input is a desirable behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant