Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@bazel/typescript npm package includes external/npm/node_modules folder #1551

Closed
gregmagolan opened this issue Jan 15, 2020 · 4 comments
Closed

@bazel/typescript npm package includes external/npm/node_modules folder #1551

gregmagolan opened this issue Jan 15, 2020 · 4 comments
Labels
bug

Comments

@gregmagolan
Copy link
Collaborator

See here https://unpkg.com/browse/@bazel/typescript@1.1.0/external/npm/node_modules/

Also apparent here: https://github.com/gregmagolan/rules_nodejs-builds/tree/labs/%40bazel_typescript
@gregmagolan gregmagolan mentioned this issue Jan 15, 2020
Closed
@mattem
Copy link
Collaborator

mattem commented Jan 19, 2020

Ah, this seems to be what @kylecordes was describing in #1499.

@kylecordes kylecordes mentioned this issue Jan 25, 2020
Closed
@kylecordes
Copy link

Wow, it never occurred to me to go look at erroneously included externals from there, rather than a packaging bug, as the cause.

@alexeagle
Copy link
Collaborator

Kyle reported first so I'll close this as dupe of #1499

@gregmagolan
Copy link
Collaborator Author

Fixed with 8089999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kylecordes @alexeagle @gregmagolan @mattem