Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/esbuild: Rename flag error-limit to log-limit #2578

Closed
uhthomas opened this issue Mar 31, 2021 · 1 comment
Closed

packages/esbuild: Rename flag error-limit to log-limit #2578

uhthomas opened this issue Mar 31, 2021 · 1 comment

Comments

@uhthomas
Copy link

🐞 bug report

Affected Rule

The issue is caused by the rule: packages/esbuild

Is this a regression?

No.

Description

Esbuild has unexpectedly introduced this change evanw/esbuild@7d30f83 where the flag error-limit has been renamed to log-limit. This breaks builds using any versions after this commit was introduced. For example, v0.11.21.

🔬 Minimal Reproduction

Try to build any examples which use esbuild using esbuild v0.11.2.

🔥 Exception or Error

Use --sandbox_debug to see verbose messages from the sandbox
 > error: Invalid build flag: "--error-limit=0"

🌍 Your Environment

Operating System:

uname -a
Darwin <redacted> 19.6.0 Darwin Kernel Version 19.6.0: Tue Jan 12 22:13:05 PST 2021; root:xnu-6153.141.16~1/RELEASE_X86_64 x86_64

Output of bazel version:

Build label: 4.0.0-homebrew
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Sat Jan 23 02:12:39 2021 (1611367959)
Build timestamp: 1611367959
Build timestamp as int: 1611367959

Rules_nodejs version:

(Please check that you have matching versions between WORKSPACE file and @bazel/* npm packages.)

3.2.3

Anything else relevant?

@mattem
Copy link
Collaborator

mattem commented Mar 31, 2021

Duplicate of #2552, see linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants