Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js_library not including .jsx files #3487

Closed
maapteh opened this issue Jun 20, 2022 · 0 comments · Fixed by #3488
Closed

js_library not including .jsx files #3487

maapteh opened this issue Jun 20, 2022 · 0 comments · Fixed by #3488

Comments

@maapteh
Copy link
Contributor

maapteh commented Jun 20, 2022

Description

In js_library im missing the '.jsx' files as part of being an accepted source. It currently only includes .js files

https://github.com/bazelbuild/rules_nodejs/blob/stable/internal/js_library/js_library.bzl

Describe the solution you'd like

I would like the js library to also inject the jsx files as well so i dont have to hack around it (my experience so far). And although arbitrary since most users first use transpilation themselves since jsx is never a true JavaScript file while js and mjs are, i still would like to have the option. So maybe set is as option to also include it?

Describe alternatives you've considered

For other dependencies i first transpile stuff using ts_library and then passed it on. But for storybook the compilation is done inside the storybook building tools, so not usable. I can move back to not use the jsx syntax but since its the React way of doing a component (tsx), i see no reason why not to include these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant