-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Server][6.3.2] Improve ALREADY_EXISTS status handling #1452
base: main
Are you sure you want to change the base?
[Server][6.3.2] Improve ALREADY_EXISTS status handling #1452
Conversation
Sending an ALREADY_EXISTS for duplicated writes. Sometimes we may have this value after the client makes a find missing blobs request This also fixes an issue with some serious log spam
I was having a trace like this:
|
log.log(Level.FINE, format("already wrote data for %s", name), e); | ||
errorResponse(status.asException()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional this fine logging with if (errorResponse...
to be complete - errorResponse returns false if we've already delivered a response to the stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM - I've wrapped it in this conditional 👍
Sending an ALREADY_EXISTS for duplicated writes. Sometimes we may have this value after the client makes a find missing blobs request. In 6.4.0rc1 there were a few improvements to this by the way. It seems like this is a better treatment of it regardless
This also fixes an issue with some serious log spam.