Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Record Service and Message names in Proto's fileInfo #1843

Open
ckilian867 opened this issue Jul 19, 2024 · 0 comments
Open

Comments

@ckilian867
Copy link
Contributor

Currently, while the proto extension parses the proto file, it uses regex to find certain information about the file, including package, options, and imports.

One of the things being parsed is services. However, this is currently just to track a boolean on whether there are any services in the current file.

For determining Java imports, we'd need to know the Java package option (already available) as well as the names of the messages and services being generated.

This feature request would be to add two new fields to FileInfo: ServiceNames and MessageNames (or something similar). In addition to the current information parsed from the proto file, we'd record this information and return it to the caller for later use.

We'd be happy to implement this and raise a PR, but wanted to understand any concerns with this approach before spending cycles on implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant