revert: revert: Use `patch` from `@bazel_tools//tools/build_defs/repo` #1381

tyler-french · 2022-11-28T22:14:33Z

What type of PR is this?

Bug fix

What package or component does this PR mostly affect?

go_repository

What does this PR do? Why is it needed?

This diff reverts #1277, which reverted #1269

This diff uses Bazel's implementation of patch rather than the system, making it hermetic.

The main issues described in #1277 no longer exist:

It seems like by using the native repository_ctx.path(file, strip)
in bazel_tools, we would be applying the patches to the repository
archive before BUILD file generation. This is not desirable as
patches on top of go_repository are often used to modify the BUILD files
themselves.

The patch is always called after build file generation: https://github.com/bazelbuild/bazel-gazelle/blob/05f5493ca9b74f037dde928721dc01ffaa6de1a2/internal/go_repository.bzl#L282-L293

Another difference is that patch allows patch files without trailing
blank/empty lines while repository_ctx.patch() would fail to recognize
EOF in patch files without a trailing empty line:

This also appears to be fixed. However, this is extremely minor, and there should be very few affected cases here.

One note, is that repository_ctx.patch() is a bit more strict, and usually requires more "recent" patches with accurate line numbers.

Which issues(s) does this PR fix?

Fixes #1380

…ils.bzl bazel-contrib#1269

linzhp · 2022-11-28T22:20:03Z

@sluongng Can you take a look? We tested it with several go_repository rules used by Uber that requires patching BUILD.bazel files, they all worked

sluongng · 2022-11-29T10:47:12Z

Unfortunately, I don't have a repo to test this with right now.

But iirc, the problem was not with the ordering of the patch() call after BUILD file generation. The problem was patch was being run over a fresh copy of the downloaded archived, not the copy with BUILD file generated within.

So I don't think the PR description properly addressed what was changed and fixed the issue.
I wonder if the bzlmod activities that @meteorcloudy and @fmeum implemented recently accidentally fixed this.

If that's the case, I suspect we should be able to bisect this somehow to find the fixed commit.
It's could be important to let our users know about Bazel version incompatibility with rules_go around this change.

The change itself looks good to me.

meteorcloudy · 2022-11-29T10:54:23Z

I wonder if the bzlmod activities that @meteorcloudy and @fmeum implemented recently accidentally fixed this.

Did you mean this commit: bazelbuild/bazel@e9a4e93? But I don't see how it changed where the patch was executed. So probably not?

tyler-french · 2022-11-29T14:59:09Z

But iirc, the problem was not with the ordering of the patch() call after the BUILD file generation. The problem was patch was being run over a fresh copy of the downloaded archived, not the copy with the BUILD file generated within.

Maybe our behavior is different, but for us, the patches are properly applied to $(bazel info output_base)/external. In many cases, the patches are applied to BUILD.bazel files that do not exist in the open source version and are generated by gazelle.

This is probably worth confirming.

linzhp

The problem was patch was being run over a fresh copy of the downloaded archived, not the copy with BUILD file generated within.

We don't see a way to reproduce this issue, so I am going to merge this for now. Feel free to create an issue with an example repo if it persists.

dpoluyanov · 2023-01-23T07:39:23Z

It hits us too, so I've created an repro repository https://github.com/dpoluyanov/bazel-gazelle-gh-1381 and a new issue: #1424

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/avast/retry-go/v4](https://togithub.com/avast/retry-go) | require | patch | `v4.3.1` -> `v4.3.2` | | [github.com/bazelbuild/bazel-gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | require | minor | `v0.28.0` -> `v0.29.0` | | [github.com/bazelbuild/buildtools](https://togithub.com/bazelbuild/buildtools) | require | digest | `762712d` -> `180a94a` | | [github.com/evanw/esbuild](https://togithub.com/evanw/esbuild) | require | minor | `v0.16.7` -> `v0.17.2` | | [github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway) | require | minor | `v2.14.0` -> `v2.15.0` | | [github.com/grpc-ecosystem/grpc-health-probe](https://togithub.com/grpc-ecosystem/grpc-health-probe) | require | patch | `v0.4.14` -> `v0.4.15` | | [github.com/mattn/go-isatty](https://togithub.com/mattn/go-isatty) | require | patch | `v0.0.16` -> `v0.0.17` | | [github.com/onsi/ginkgo/v2](https://togithub.com/onsi/ginkgo) | require | minor | `v2.6.1` -> `v2.7.0` | | [github.com/onsi/gomega](https://togithub.com/onsi/gomega) | require | minor | `v1.24.2` -> `v1.25.0` | | [github.com/slack-go/slack](https://togithub.com/slack-go/slack) | require | minor | `v0.11.4` -> `v0.12.1` | | [golang.org/x/exp](https://togithub.com/golang/exp) | require | digest | `0915cd7` -> `a68e582` | | [google.golang.org/genproto](https://togithub.com/googleapis/go-genproto) | require | digest | `23e4bf6` -> `28d6b97` | | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | require | minor | `v1.51.0` -> `v1.52.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>avast/retry-go</summary> ### [`v4.3.2`](https://togithub.com/avast/retry-go/compare/v4.3.1...v4.3.2) [Compare Source](https://togithub.com/avast/retry-go/compare/v4.3.1...v4.3.2) </details> <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.29.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.29.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.28.0...v0.29.0) #### What's Changed - bzlmod: Update Publish to BCR app config by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1363](https://togithub.com/bazelbuild/bazel-gazelle/pull/1363) - Fix: Skip default_visibility extension logic if no BUILD.bazel file present by [@dnathe4th](https://togithub.com/dnathe4th) in [https://github.com/bazelbuild/bazel-gazelle/pull/1364](https://togithub.com/bazelbuild/bazel-gazelle/pull/1364) - fix updateStmt makeslice panic by [@pcj](https://togithub.com/pcj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1371](https://togithub.com/bazelbuild/bazel-gazelle/pull/1371) - bzlmod: Add missing `strip_prefix` field to `source.template.json` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1375](https://togithub.com/bazelbuild/bazel-gazelle/pull/1375) - feat: support common test args in `gazelle_generation_test` by [@cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1377](https://togithub.com/bazelbuild/bazel-gazelle/pull/1377) - Make the new facts pacakge public by [@linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1378](https://togithub.com/bazelbuild/bazel-gazelle/pull/1378) - fix: add timeout message for `gazelle_generation_test` by [@cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1383](https://togithub.com/bazelbuild/bazel-gazelle/pull/1383) - bzlmod: Add missing repository metadata by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1387](https://togithub.com/bazelbuild/bazel-gazelle/pull/1387) - Replace `cfg = "host"` with `cfg = "exec"` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1395](https://togithub.com/bazelbuild/bazel-gazelle/pull/1395) - upgrade rules_go to 0.37.0 by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/bazel-gazelle/pull/1386](https://togithub.com/bazelbuild/bazel-gazelle/pull/1386) - Fix embed on windows by [@st3veV](https://togithub.com/st3veV) in [https://github.com/bazelbuild/bazel-gazelle/pull/1361](https://togithub.com/bazelbuild/bazel-gazelle/pull/1361) - Update bazel-skylib to 1.3.0. by [@benjaminp](https://togithub.com/benjaminp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1367](https://togithub.com/bazelbuild/bazel-gazelle/pull/1367) - Fix Directives anchor by [@jmthvt](https://togithub.com/jmthvt) in [https://github.com/bazelbuild/bazel-gazelle/pull/1353](https://togithub.com/bazelbuild/bazel-gazelle/pull/1353) - Use `patch` from `@bazel_tools//tools/build_defs/repo` by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1381](https://togithub.com/bazelbuild/bazel-gazelle/pull/1381) - Add link to BenchSci's rules_nodejs_gazelle extension by [@ColinHeathman](https://togithub.com/ColinHeathman) in [https://github.com/bazelbuild/bazel-gazelle/pull/1369](https://togithub.com/bazelbuild/bazel-gazelle/pull/1369) - bzlmod: Skip Go modules available as Bazel modules by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1403](https://togithub.com/bazelbuild/bazel-gazelle/pull/1403) - repo: opportunistically populate RemoteCache from go.mod by [@jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/bazel-gazelle/pull/1396](https://togithub.com/bazelbuild/bazel-gazelle/pull/1396) - Fix Gazelle with `--incompatible_disallow_empty_glob` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1405](https://togithub.com/bazelbuild/bazel-gazelle/pull/1405) - chore: remove experimental warning from bzlmod module by [@alexeagle](https://togithub.com/alexeagle) in [https://github.com/bazelbuild/bazel-gazelle/pull/1406](https://togithub.com/bazelbuild/bazel-gazelle/pull/1406) - chore: add Swift extension to language list by [@cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1412](https://togithub.com/bazelbuild/bazel-gazelle/pull/1412) - Update everything for release prep, add releaser tool by [@dnathe4th](https://togithub.com/dnathe4th) in [https://github.com/bazelbuild/bazel-gazelle/pull/1373](https://togithub.com/bazelbuild/bazel-gazelle/pull/1373) - adding go version and std_package_list to releaser by [@linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1415](https://togithub.com/bazelbuild/bazel-gazelle/pull/1415) #### New Contributors - [@damingerdai](https://togithub.com/damingerdai) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1362](https://togithub.com/bazelbuild/bazel-gazelle/pull/1362) - [@st3veV](https://togithub.com/st3veV) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1361](https://togithub.com/bazelbuild/bazel-gazelle/pull/1361) - [@benjaminp](https://togithub.com/benjaminp) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1367](https://togithub.com/bazelbuild/bazel-gazelle/pull/1367) - [@jmthvt](https://togithub.com/jmthvt) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1353](https://togithub.com/bazelbuild/bazel-gazelle/pull/1353) - [@ColinHeathman](https://togithub.com/ColinHeathman) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1369](https://togithub.com/bazelbuild/bazel-gazelle/pull/1369) **Full Changelog**: https://github.com/bazelbuild/bazel-gazelle/compare/v0.28.0...v0.29.0 </details> <details> <summary>evanw/esbuild</summary> ### [`v0.17.2`](https://togithub.com/evanw/esbuild/releases/tag/v0.17.2) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.17.1...v0.17.2) - Add `onDispose` to the plugin API ([#2140](https://togithub.com/evanw/esbuild/issues/2140), [#2205](https://togithub.com/evanw/esbuild/issues/2205)) If your plugin wants to perform some cleanup after it's no longer going to be used, you can now use the `onDispose` API to register a callback for cleanup-related tasks. For example, if a plugin starts a long-running child process then it may want to terminate that process when the plugin is discarded. Previously there was no way to do this. Here's an example: ```js let examplePlugin = { name: 'example', setup(build) { build.onDispose(() => { console.log('This plugin is no longer used') }) }, } ``` These `onDispose` callbacks will be called after every `build()` call regardless of whether the build failed or not as well as after the first `dispose()` call on a given build context. ### [`v0.17.1`](https://togithub.com/evanw/esbuild/releases/tag/v0.17.1) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.17.0...v0.17.1) - Make it possible to cancel a build ([#2725](https://togithub.com/evanw/esbuild/issues/2725)) The context object introduced in version 0.17.0 has a new `cancel()` method. You can use it to cancel a long-running build so that you can start a new one without needing to wait for the previous one to finish. When this happens, the previous build should always have at least one error and have no output files (i.e. it will be a failed build). Using it might look something like this: - JS: ```js let ctx = await esbuild.context({ // ... }) let rebuildWithTimeLimit = timeLimit => { let timeout = setTimeout(() => ctx.cancel(), timeLimit) return ctx.rebuild().finally(() => clearTimeout(timeout)) } let build = await rebuildWithTimeLimit(500) ``` - Go: ```go ctx, err := api.Context(api.BuildOptions{ // ... }) if err != nil { return } rebuildWithTimeLimit := func(timeLimit time.Duration) api.BuildResult { t := time.NewTimer(timeLimit) go func() { <-t.C ctx.Cancel() }() result := ctx.Rebuild() t.Stop() return result } build := rebuildWithTimeLimit(500 * time.Millisecond) ``` This API is a quick implementation and isn't maximally efficient, so the build may continue to do some work for a little bit before stopping. For example, I have added stop points between each top-level phase of the bundler and in the main module graph traversal loop, but I haven't added fine-grained stop points within the internals of the linker. How quickly esbuild stops can be improved in future releases. This means you'll want to wait for `cancel()` and/or the previous `rebuild()` to finish (i.e. await the returned promise in JavaScript) before starting a new build, otherwise `rebuild()` will give you the just-canceled build that still hasn't ended yet. Note that `onEnd` callbacks will still be run regardless of whether or not the build was canceled. - Fix server-sent events without `servedir` ([#2827](https://togithub.com/evanw/esbuild/issues/2827)) The server-sent events for live reload were incorrectly using `servedir` to calculate the path to modified output files. This means events couldn't be sent when `servedir` wasn't specified. This release uses the internal output directory (which is always present) instead of `servedir` (which might be omitted), so live reload should now work when `servedir` is not specified. - Custom entry point output paths now work with the `copy` loader ([#2828](https://togithub.com/evanw/esbuild/issues/2828)) Entry points can optionally provide custom output paths to change the path of the generated output file. For example, `esbuild foo=abc.js bar=xyz.js --outdir=out` generates the files `out/foo.js` and `out/bar.js`. However, this previously didn't work when using the `copy` loader due to an oversight. This bug has been fixed. For example, you can now do `esbuild foo=abc.html bar=xyz.html --outdir=out --loader:.html=copy` to generate the files `out/foo.html` and `out/bar.html`. - The JS API can now take an array of objects ([#2828](https://togithub.com/evanw/esbuild/issues/2828)) Previously it was not possible to specify two entry points with the same custom output path using the JS API, although it was possible to do this with the Go API and the CLI. This will not cause a collision if both entry points use different extensions (e.g. if one uses `.js` and the other uses `.css`). You can now pass the JS API an array of objects to work around this API limitation: ```js // The previous API didn't let you specify duplicate output paths let result = await esbuild.build({ entryPoints: { // This object literal contains a duplicate key, so one is ignored 'dist': 'foo.js', 'dist': 'bar.css', }, }) // You can now specify duplicate output paths as an array of objects let result = await esbuild.build({ entryPoints: [ { in: 'foo.js', out: 'dist' }, { in: 'bar.css', out: 'dist' }, ], }) ``` ### [`v0.17.0`](https://togithub.com/evanw/esbuild/releases/tag/v0.17.0) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.17...v0.17.0) **This release deliberately contains backwards-incompatible changes.** To avoid automatically picking up releases like this, you should either be pinning the exact version of `esbuild` in your `package.json` file (recommended) or be using a version range syntax that only accepts patch upgrades such as `^0.16.0` or `~0.16.0`. See npm's documentation about [semver](https://docs.npmjs.com/cli/v6/using-npm/semver/) for more information. At a high level, the breaking changes in this release fix some long-standing issues with the design of esbuild's incremental, watch, and serve APIs. This release also introduces some exciting new features such as live reloading. In detail: - Move everything related to incremental builds to a new `context` API ([#1037](https://togithub.com/evanw/esbuild/issues/1037), [#1606](https://togithub.com/evanw/esbuild/issues/1606), [#2280](https://togithub.com/evanw/esbuild/issues/2280), [#2418](https://togithub.com/evanw/esbuild/issues/2418)) This change removes the `incremental` and `watch` options as well as the `serve()` method, and introduces a new `context()` method. The context method takes the same arguments as the `build()` method but only validates its arguments and does not do an initial build. Instead, builds can be triggered using the `rebuild()`, `watch()`, and `serve()` methods on the returned context object. The new context API looks like this: ```js // Create a context for incremental builds const context = await esbuild.context({ entryPoints: ['app.ts'], bundle: true, }) // Manually do an incremental build const result = await context.rebuild() // Enable watch mode await context.watch() // Enable serve mode await context.serve() // Dispose of the context context.dispose() ``` The switch to the context API solves a major issue with the previous API which is that if the initial build fails, a promise is thrown in JavaScript which prevents you from accessing the returned result object. That prevented you from setting up long-running operations such as watch mode when the initial build contained errors. It also makes tearing down incremental builds simpler as there is now a single way to do it instead of three separate ways. In addition, this release also makes some subtle changes to how incremental builds work. Previously every call to `rebuild()` started a new build. If you weren't careful, then builds could actually overlap. This doesn't cause any problems with esbuild itself, but could potentially cause problems with plugins (esbuild doesn't even give you a way to identify which overlapping build a given plugin callback is running on). Overlapping builds also arguably aren't useful, or at least aren't useful enough to justify the confusion and complexity that they bring. With this release, there is now only ever a single active build per context. Calling `rebuild()` before the previous rebuild has finished now "merges" with the existing rebuild instead of starting a new build. - Allow using `watch` and `serve` together ([#805](https://togithub.com/evanw/esbuild/issues/805), [#1650](https://togithub.com/evanw/esbuild/issues/1650), [#2576](https://togithub.com/evanw/esbuild/issues/2576)) Previously it was not possible to use watch mode and serve mode together. The rationale was that watch mode is one way of automatically rebuilding your project and serve mode is another (since serve mode automatically rebuilds on every request). However, people want to combine these two features to make "live reloading" where the browser automatically reloads the page when files are changed on the file system. This release now allows you to use these two features together. You can only call the `watch()` and `serve()` APIs once each per context, but if you call them together on the same context then esbuild will automatically rebuild both when files on the file system are changed *and* when the server serves a request. - Support "live reloading" through server-sent events ([#802](https://togithub.com/evanw/esbuild/issues/802)) [Server-sent events](https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events/Using_server-sent_events) are a simple way to pass one-directional messages asynchronously from the server to the client. Serve mode now provides a `/esbuild` endpoint with an `change` event that triggers every time esbuild's output changes. So you can now implement simple "live reloading" (i.e. reloading the page when a file is edited and saved) like this: ```js new EventSource('/esbuild').addEventListener('change', () => location.reload()) ``` The event payload is a JSON object with the following shape: ```ts interface ChangeEvent { added: string[] removed: string[] updated: string[] } ``` This JSON should also enable more complex live reloading scenarios. For example, the following code hot-swaps changed CSS `<link>` tags in place without reloading the page (but still reloads when there are other types of changes): ```js new EventSource('/esbuild').addEventListener('change', e => { const { added, removed, updated } = JSON.parse(e.data) if (!added.length && !removed.length && updated.length === 1) { for (const link of document.getElementsByTagName("link")) { const url = new URL(link.href) if (url.host === location.host && url.pathname === updated[0]) { const next = link.cloneNode() next.href = updated[0] + '?' + Math.random().toString(36).slice(2) next.onload = () => link.remove() link.parentNode.insertBefore(next, link.nextSibling) return } } } location.reload() }) ``` Implementing live reloading like this has a few known caveats: - These events only trigger when esbuild's output changes. They do not trigger when files unrelated to the build being watched are changed. If your HTML file references other files that esbuild doesn't know about and those files are changed, you can either manually reload the page or you can implement your own live reloading infrastructure instead of using esbuild's built-in behavior. - The `EventSource` API is supposed to automatically reconnect for you. However, there's a bug in Firefox that breaks this if the server is ever temporarily unreachable: https://bugzilla.mozilla.org/show_bug.cgi?id=1809332. Workarounds are to use any other browser, to manually reload the page if this happens, or to write more complicated code that manually closes and re-creates the `EventSource` object if there is a connection error. I'm hopeful that this bug will be fixed. - Browser vendors have decided to not implement HTTP/2 without TLS. This means that each `/esbuild` event source will take up one of your precious 6 simultaneous per-domain HTTP/1.1 connections. So if you open more than six HTTP tabs that use this live-reloading technique, you will be unable to use live reloading in some of those tabs (and other things will likely also break). The workaround is to enable HTTPS, which is now possible to do in esbuild itself (see below). - Add built-in support for HTTPS ([#2169](https://togithub.com/evanw/esbuild/issues/2169)) You can now tell esbuild's built-in development server to use HTTPS instead of HTTP. This is sometimes necessary because browser vendors have started making modern web features unavailable to HTTP websites. Previously you had to put a proxy in front of esbuild to enable HTTPS since esbuild's development server only supported HTTP. But with this release, you can now enable HTTPS with esbuild without an additional proxy. To enable HTTPS with esbuild: 1. Generate a self-signed certificate. There are many ways to do this. Here's one way, assuming you have `openssl` installed: openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -days 9999 -nodes -subj /CN=127.0.0.1 2. Add `--keyfile=key.pem` and `--certfile=cert.pem` to your esbuild development server command 3. Click past the scary warning in your browser when you load your page If you have more complex needs than this, you can still put a proxy in front of esbuild and use that for HTTPS instead. Note that if you see the message "Client sent an HTTP request to an HTTPS server" when you load your page, then you are using the incorrect protocol. Replace `http://` with `https://` in your browser's URL bar. Keep in mind that esbuild's HTTPS support has nothing to do with security. The only reason esbuild now supports HTTPS is because browsers have made it impossible to do local development with certain modern web features without jumping through these extra hoops. *Please do not use esbuild's development server for anything that needs to be secure.* It's only intended for local development and no considerations have been made for production environments whatsoever. - Better support copying `index.html` into the output directory ([#621](https://togithub.com/evanw/esbuild/issues/621), [#1771](https://togithub.com/evanw/esbuild/issues/1771)) Right now esbuild only supports JavaScript and CSS as first-class content types. Previously this meant that if you were building a website with a HTML file, a JavaScript file, and a CSS file, you could use esbuild to build the JavaScript file and the CSS file into the output directory but not to copy the HTML file into the output directory. You needed a separate `cp` command for that. Or so I thought. It turns out that the `copy` loader added in version 0.14.44 of esbuild is sufficient to have esbuild copy the HTML file into the output directory as well. You can add something like `index.html --loader:.html=copy` and esbuild will copy `index.html` into the output directory for you. The benefits of this are a) you don't need a separate `cp` command and b) the `index.html` file will automatically be re-copied when esbuild is in watch mode and the contents of `index.html` are edited. This also goes for other non-HTML file types that you might want to copy. This pretty much already worked. The one thing that didn't work was that esbuild's built-in development server previously only supported implicitly loading `index.html` (e.g. loading `/about/index.html` when you visit `/about/`) when `index.html` existed on the file system. Previously esbuild didn't support implicitly loading `index.html` if it was a build result. That bug has been fixed with this release so it should now be practical to use the `copy` loader to do this. - Fix `onEnd` not being called in serve mode ([#1384](https://togithub.com/evanw/esbuild/issues/1384)) Previous releases had a bug where plugin `onEnd` callbacks weren't called when using the top-level `serve()` API. This API no longer exists and the internals have been reimplemented such that `onEnd` callbacks should now always be called at the end of every build. - Incremental builds now write out build results differently ([#2104](https://togithub.com/evanw/esbuild/issues/2104)) Previously build results were always written out after every build. However, this could cause the output directory to fill up with files from old builds if code splitting was enabled, since the file names for code splitting chunks contain content hashes and old files were not deleted. With this release, incremental builds in esbuild will now delete old output files from previous builds that are no longer relevant. Subsequent incremental builds will also no longer overwrite output files whose contents haven't changed since the previous incremental build. - The `onRebuild` watch mode callback was removed ([#980](https://togithub.com/evanw/esbuild/issues/980), [#2499](https://togithub.com/evanw/esbuild/issues/2499)) Previously watch mode accepted an `onRebuild` callback which was called whenever watch mode rebuilt something. This was not great in practice because if you are running code after a build, you likely want that code to run after every build, not just after the second and subsequent builds. This release removes option to provide an `onRebuild` callback. You can create a plugin with an `onEnd` callback instead. The `onEnd` plugin API already exists, and is a way to run some code after every build. - You can now return errors from `onEnd` ([#2625](https://togithub.com/evanw/esbuild/issues/2625)) It's now possible to add additional build errors and/or warnings to the current build from within your `onEnd` callback by returning them in an array. This is identical to how the `onStart` callback already works. The evaluation of `onEnd` callbacks have been moved around a bit internally to make this possible. Note that the build will only fail (i.e. reject the promise) if the additional errors are returned from `onEnd`. Adding additional errors to the result object that's passed to `onEnd` won't affect esbuild's behavior at all. - Print URLs and ports from the Go and JS APIs ([#2393](https://togithub.com/evanw/esbuild/issues/2393)) Previously esbuild's CLI printed out something like this when serve mode is active: > Local: http://127.0.0.1:8000/ > Network: http://192.168.0.1:8000/ The CLI still does this, but now the JS and Go serve mode APIs will do this too. This only happens when the log level is set to `verbose`, `debug`, or `info` but not when it's set to `warning`, `error`, or `silent`. ##### Upgrade guide for existing code: - Rebuild (a.k.a. incremental build): Before: ```js const result = await esbuild.build({ ...buildOptions, incremental: true }); builds.push(result); for (let i = 0; i < 4; i++) builds.push(await result.rebuild()); await result.rebuild.dispose(); // To free resources ``` After: ```js const ctx = await esbuild.context(buildOptions); for (let i = 0; i < 5; i++) builds.push(await ctx.rebuild()); await ctx.dispose(); // To free resources ``` Previously the first build was done differently than subsequent builds. Now both the first build and subsequent builds are done using the same API. - Serve: Before: ```js const serveResult = await esbuild.serve(serveOptions, buildOptions); ... serveResult.stop(); await serveResult.wait; // To free resources ``` After: ```js const ctx = await esbuild.context(buildOptions); const serveResult = await ctx.serve(serveOptions); ... await ctx.dispose(); // To free resources ``` - Watch: Before: ```js const result = await esbuild.build({ ...buildOptions, watch: true }); ... result.stop(); // To free resources ``` After: ```js const ctx = await esbuild.context(buildOptions); await ctx.watch(); ... await ctx.dispose(); // To free resources ``` - Watch with `onRebuild`: Before: ```js const onRebuild = (error, result) => { if (error) console.log('subsequent build:', error); else console.log('subsequent build:', result); }; try { const result = await esbuild.build({ ...buildOptions, watch: { onRebuild } }); console.log('first build:', result); ... result.stop(); // To free resources } catch (error) { console.log('first build:', error); } ``` After: ```js const plugins = [{ name: 'my-plugin', setup(build) { let count = 0; build.onEnd(result => { if (count++ === 0) console.log('first build:', result); else console.log('subsequent build:', result); }); }, }]; const ctx = await esbuild.context({ ...buildOptions, plugins }); await ctx.watch(); ... await ctx.dispose(); // To free resources ``` The `onRebuild` function has now been removed. The replacement is to make a plugin with an `onEnd` callback. Previously `onRebuild` did not fire for the first build (only for subsequent builds). This was usually problematic, so using `onEnd` instead of `onRebuild` is likely less error-prone. But if you need to emulate the old behavior of `onRebuild` that ignores the first build, then you'll need to manually count and ignore the first build in your plugin (as demonstrated above). Notice how all of these API calls are now done off the new context object. You should now be able to use all three kinds of incremental builds (`rebuild`, `serve`, and `watch`) together on the same context object. Also notice how calling `dispose` on the context is now the common way to discard the context and free resources in all of these situations. ### [`v0.16.17`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.17) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.16...v0.16.17) - Fix additional comment-related regressions ([#2814](https://togithub.com/evanw/esbuild/issues/2814)) This release fixes more edge cases where the new comment preservation behavior that was added in 0.16.14 could introduce syntax errors. Specifically: ```js x = () => (/* comment */ {}) for ((/* comment */ let).x of y) ; function *f() { yield (/* comment */class {}) } ``` These cases caused esbuild to generate code with a syntax error in version 0.16.14 or above. These bugs have now been fixed. ### [`v0.16.16`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.16) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.15...v0.16.16) - Fix a regression caused by comment preservation ([#2805](https://togithub.com/evanw/esbuild/issues/2805)) The new comment preservation behavior that was added in 0.16.14 introduced a regression where comments in certain locations could cause esbuild to omit certain necessary parentheses in the output. The outermost parentheses were incorrectly removed for the following syntax forms, which then introduced syntax errors: ```js (/* comment */ { x: 0 }).x; (/* comment */ function () { })(); (/* comment */ class { }).prototype; ``` This regression has been fixed. ### [`v0.16.15`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.15) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.14...v0.16.15) - Add `format` to input files in the JSON metafile data When `--metafile` is enabled, input files may now have an additional `format` field that indicates the export format used by this file. When present, the value will either be `cjs` for CommonJS-style exports or `esm` for ESM-style exports. This can be useful in bundle analysis. For example, esbuild's new [Bundle Size Analyzer](https://esbuild.github.io/analyze/) now uses this information to visualize whether ESM or CommonJS was used for each directory and file of source code (click on the CJS/ESM bar at the top). This information is helpful when trying to reduce the size of your bundle. Using the ESM variant of a dependency instead of the CommonJS variant always results in a faster and smaller bundle because it omits CommonJS wrappers, and also may result in better tree-shaking as it allows esbuild to perform tree-shaking at the statement level instead of the module level. - Fix a bundling edge case with dynamic import ([#2793](https://togithub.com/evanw/esbuild/issues/2793)) This release fixes a bug where esbuild's bundler could produce incorrect output. The problematic edge case involves the entry point importing itself using a dynamic `import()` expression in an imported file, like this: ```js // src/a.js export const A = 42; // src/b.js export const B = async () => (await import(".")).A // src/index.js export * from "./a" export * from "./b" ``` - Remove new type syntax from type declarations in the `esbuild` package ([#2798](https://togithub.com/evanw/esbuild/issues/2798)) Previously you needed to use TypeScript 4.3 or newer when using the `esbuild` package from TypeScript code due to the use of a getter in an interface in `node_modules/esbuild/lib/main.d.ts`. This release removes this newer syntax to allow people with versions of TypeScript as far back as TypeScript 3.5 to use this latest version of the `esbuild` package. Here is change that was made to esbuild's type declarations: ```diff export interface OutputFile { /** "text" as bytes */ contents: Uint8Array; /** "contents" as text (changes automatically with "contents") */ - get text(): string; + readonly text: string; } ``` ### [`v0.16.14`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.14) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.13...v0.16.14) - Preserve some comments in expressions ([#2721](https://togithub.com/evanw/esbuild/issues/2721)) Various tools give semantic meaning to comments embedded inside of expressions. For example, Webpack and Vite have special "magic comments" that can be used to affect code splitting behavior: ```js import(/* webpackChunkName: "foo" */ '../foo'); import(/* @vite-ignore */ dynamicVar); new Worker(/* webpackChunkName: "bar" */ new URL("../bar.ts", import.meta.url)); new Worker(new URL('./path', import.meta.url), /* @vite-ignore */ dynamicOptions); ``` Since esbuild can be used as a preprocessor for these tools (e.g. to strip TypeScript types), it can be problematic if esbuild doesn't do additional work to try to retain these comments. Previously esbuild special-cased Webpack comments in these specific locations in the AST. But Vite would now like to use similar comments, and likely other tools as well. So with this release, esbuild now will attempt to preserve some comments inside of expressions in more situations than before. This behavior is mainly intended to preserve these special "magic comments" that are meant for other tools to consume, although esbuild will no longer only preserve Webpack-specific comments so it should now be tool-agnostic. There is no guarantee that all such comments will be preserved (especially when `--minify-syntax` is enabled). So this change does *not* mean that esbuild is now usable as a code formatter. In particular comment preservation is more likely to happen with leading comments than with trailing comments. You should put comments that you want to be preserved *before* the relevant expression instead of after it. Also note that this change does not retain any more statement-level comments than before (i.e. comments not embedded inside of expressions). Comment preservation is not enabled when `--minify-whitespace` is enabled (which is automatically enabled when you use `--minify`). ### [`v0.16.13`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.13) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.12...v0.16.13) - Publish a new bundle visualization tool While esbuild provides bundle metadata via the `--metafile` flag, previously esbuild left analysis of it completely up to third-party tools (well, outside of the rudimentary `--analyze` flag). However, the esbuild website now has a built-in bundle visualization tool: - https://esbuild.github.io/analyze/ You can pass `--metafile` to esbuild to output bundle metadata, then upload that JSON file to this tool to visualize your bundle. This is helpful for answering questions such as: - Which packages are included in my bundle? - How did a specific file get included? - How small did a specific file compress to? - Was a specific file tree-shaken or not? I'm publishing this tool because I think esbuild should provide *some* answer to "how do I visualize my bundle" without requiring people to reach for third-party tools. At the moment the tool offers two types of visualizations: a radial "sunburst chart" and a linear "flame chart". They serve slightly different but overlapping use cases (e.g. the sunburst chart is more keyboard-accessible while the flame chart is easier with the mouse). This tool may continue to evolve over time. - Fix `--metafile` and `--mangle-cache` with `--watch` ([#1357](https://togithub.com/evanw/esbuild/issues/1357)) The CLI calls the Go API and then also writes out the metafile and/or mangle cache JSON files if those features are enabled. This extra step is necessary because these files are returned by the Go API as in-memory strings. However, this extra step accidentally didn't happen for all builds after the initial build when watch mode was enabled. This behavior used to work but it was broken in version 0.14.18 by the introduction of the mangle cache feature. This release fixes the combination of these features, so the metafile and mangle cache features should now work with watch mode. This behavior was only broken for the CLI, not for the JS or Go APIs. - Add an `original` field to the metafile The metadata file JSON now has an additional field: each import in an input file now contains the pre-resolved path in the `original` field in addition to the post-resolved path in the `path` field. This means it's now possible to run certain additional analysis over your bundle. For example, you should be able to use this to detect when the same package subpath is represented multiple times in the bundle, either because multiple versions of a package were bundled or because a package is experiencing the [dual-package hazard](https://nodejs.org/api/packages.html#dual-package-hazard). ### [`v0.16.12`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.12) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.11...v0.16.12) - Loader defaults to `js` for extensionless files ([#2776](https://togithub.com/evanw/esbuild/issues/2776)) Certain packages contain files without an extension. For example, the `yargs` package contains the file `yargs/yargs` which has no extension. Node, Webpack, and Parcel can all understand code that imports `yargs/yargs` because they assume that the file is JavaScript. However, esbuild was previously unable to understand this code because it relies on the file extension to tell it how to interpret the file. With this release, esbuild will now assume files without an extension are JavaScript files. This can be customized by setting the loader for `""` (the empty string, representing files without an extension) to another loader. For example, if you want files without an extension to be treated as CSS instead, you can do that like this: - CLI: esbuild --bundle --loader:=css - JS: ```js esbuild.build({ bundle: true, loader: { '': 'css' }, }) ``` - Go: ```go api.Build(api.BuildOptions{ Bundle: true, Loader: map[string]api.Loader{"": api.LoaderCSS}, }) ``` In addition, the `"type"` field in `package.json` files now only applies to files with an explicit `.js`, `.jsx`, `.ts`, or `.tsx` extension. Previously it was incorrectly applied by esbuild to all files that had an extension other than `.mjs`, `.mts`, `.cjs`, or `.cts` including extensionless files. So for example an extensionless file in a `"type": "module"` package is now treated as CommonJS instead of ESM. ### [`v0.16.11`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.11) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.10...v0.16.11) - Avoid a syntax error in the presence of direct `eval` ([#2761](https://togithub.com/evanw/esbuild/issues/2761)) The behavior of nested `function` declarations in JavaScript depends on whether the code is run in strict mode or not. It would be problematic if esbuild preserved nested `function` declarations in its output because then the behavior would depend on whether the output was run in strict mode or not instead of respecting the strict mode behavior of the original source code. To avoid this, esbuild transforms nested `function` declarations to preserve the intended behavior of the original source code regardless of whether the output is run in strict mode or not: ```js // Original code if (true) { function foo() {} console.log(!!foo) foo = null console.log(!!foo) } console.log(!!foo) // Transformed code if (true) { let foo2 = function() { }; var foo = foo2; console.log(!!foo2); foo2 = null; console.log(!!foo2); } console.log(!!foo); ``` In the above example, the original code should print `true false true` because it's not run in strict mode (it doesn't contain `"use strict"` and is not an ES module). The code that esbuild generates has been transformed such that it prints `true false true` regardless of whether it's run in strict mode or not. However, this transformation is impossible if the code contains direct `eval` because direct `eval` "poisons" all containing scopes by preventing anything in those scopes from being renamed. That prevents esbuild from splitting up accesses to `foo` into two separate variables with different names. Previously esbuild still did this transformation but with two variables both named `foo`, which is a syntax error. With this release esbuild will now skip doing this transformation when direct `eval` is present to avoid generating code with a syntax error. This means that the generated code may no longer behave as intended since the behavior depends on the run-time strict mode setting instead of the strict mode setting present in the original source code. To fix this problem, you will need to remove the use of direct `eval`. - Fix a bundling scenario involving multiple symlinks ([#2773](https://togithub.com/evanw/esbuild/issues/2773), [#2774](https://togithub.com/evanw/esbuild/issues/2774)) This release contains a fix for a bundling scenario involving an import path where multiple path segments are symlinks. Previously esbuild was unable to resolve certain import paths in this scenario, but these import paths should now work starting with this release. This fix was contributed by [@onebytegone](https://togithub.com/onebytegone). ### [`v0.16.10`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.10) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.9...v0.16.10) - Change the default "legal comment" behavior again ([#2745](https://togithub.com/evanw/esbuild/issues/2745)) The legal comments feature automatically gathers comments containing `@license` or `@preserve` and puts the comments somewhere (either in the generated code or in a separate file). This behavior used to be on by default but was disabled by default in version 0.16.0 because automatically inserting comments is potentially confusing and misleading. These comments can appear to be assigning the copyright of your code to another entity. And this behavior can be especially problematic if it happens automatically by default since you may not even be aware of it happening. For example, if you bundle the TypeScript compiler the preserving legal comments means your source code would contain this comment, which appears to be assigning the copyright of all of your code to Microsoft: ```js /*! ***************************************************************************** Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 THIS CODE IS PROVIDED ON AN *AS IS* BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING WITHOUT LIMITATION ANY IMPLIED WARRANTIES OR CONDITIONS OF TITLE, FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABLITY OR NON-INFRINGEMENT. See the Apache Version 2.0 License for specific language governing permissions and limitations under the License. ***************************************************************************** */ ``` However, people have asked for this feature to be re-enabled by default. To resolve the confusion about what these comments are applying to, esbuild's default behavior will now be to attempt to describe which package the comments are coming from. So while this feature has been re-enabled by default, the output will now look something like this instead: ```js /*! Bundled license information: typescript/lib/typescript.js: (*! ***************************************************************************** Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 THIS CODE IS PROVIDED ON AN *AS IS* BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING WITHOUT LIMITATION ANY IMPLIED WARRANTIES OR CONDITIONS OF TITLE, FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABLITY OR NON-INFRINGEMENT. See the Apache Version 2.0 License for specific language governing permissions and limitations under the License. ***************************************************************************** *) */ ``` Note that you can still customize this behavior with the `--legal-comments=` flag. For example, you can use `--legal-comments=none` to turn this off, or you can use `--legal-comments=linked` to put these comments in a separate `.LEGAL.txt` file instead. - Enable `external` legal comments with the transform API ([#2390](https://togithub.com/evanw/esbuild/issues/2390)) Previously esbuild's transform API only supported `none`, `inline`, or `eof` legal comments. With this release, `external` legal comments are now also supported with the transform API. This only applies to the JS and Go APIs, not to the CLI, and looks like this: - JS: ```js const { code, legalComments } = await esbuild.transform(input, { legalComments: 'external', }) ``` - Go: ```go result := api.Transform(input, api.TransformOptions{ LegalComments: api.LegalCommentsEndOfFile, }) code := result.Code legalComments := result.LegalComments ``` - Fix duplicate function declaration edge cases ([#2757](https://togithub.com/evanw/esbuild/issues/2757)) The change in the previous release to forbid duplicate function declarations in certain cases accidentally forbid some edge cases that should have been allowed. Specifically duplicate function declarations are forbidden in nested blocks in strict mode and at the top level of modules, but are allowed when they are declared at the top level of function bodies. This release fixes the regression by re-allowing the last case. - Allow package subpaths with `alias` ([#2715](https://togithub.com/evanw/esbuild/issues/2715)) Previously the names passed to the `alias` feature had to be the name of a package (with or without a package scope). With this release, you can now also use the `alias` feature with package subpaths. So for example you can now create an alias that substitutes `@org/pkg/lib` with something else. ### [`v0.16.9`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.9) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.8...v0.16.9) - Update to Unicode 15.0.0 The character tables that determine which characters form valid JavaScript identifiers have been updated from Unicode version 14.0.0 to the newly-released Unicode version 15.0.0. I'm not putting an example in the release notes because all of the new characters will likely just show up as little squares since fonts haven't been updated yet. But you can read https://www.unicode.org/versions/Unicode15.0.0/#Summary for more information about the changes. - Disallow duplicate lexically-declared names in nested blocks and in strict mode In strict mode or in a nested block, it's supposed to be a syntax error to declare two symbols with the same name unless all duplicate entries are either `function` declarations or all `var` declarations. However, esbuild was overly permissive and allowed this when duplicate entries were either `function` declarations or `var` declarations (even if they were mixed). This check has now been made more restrictive to match the JavaScript specification: ```js // JavaScript allows this var a function a() {} { var b var b function c() {} function c() {} } // JavaScript doesn't allow this { var d function d() {} } ``` - Add a type declaration for the new `empty` loader ([#2755](https://togithub.com/evanw/esbuild/pull/2755)) I forgot to add this in the previous release. It has now been added. This fix was contributed by [@fz6m](https://togithub.com/fz6m). - Add support for the `v` flag in regular expression literals People are currently working on adding a `v` flag to JavaScript regular expresions. You can read more about this flag here: https://v8.dev/features/regexp-v-flag. This release adds support for parsing this flag, so esbuild will now no longer consider regular expression literals with this flag to be a syntax error. If the target is set to something other than `esnext`, esbuild will transform regular expression literals containing this flag into a `new RegExp()` constructor call so the resulting code doesn't have a syntax error. This enables you to provide a polyfill for `RegExp` that implements the `v` flag to get your code to work at run-time. While esbuild doesn't typically adopt proposals until they're already shipping in a real JavaScript run-time, I'm adding it now because a) esbuild's implementation doesn't need to change as the proposal evolves, b) this isn't really new syntax since regular expression literals already have flags, and c) esbuild's implementation is a trivial pass-through anyway. - Avoid keeping the name of classes with static `name` properties The `--keep-names` property attempts to preserve the original value of the `name` property for functions and classes even when identifiers are renamed by the minifier or to avoid a name collision. This is currently done by generating code to assign a string to the `name` property on the function or class object. However, this should not be done for classes with a static `name` property since in that case the explicitly-defined `name` property overwrites the automatically-generated class name. With this release, esbuild will now no longer attempt to preserve the `name` property for classes with a static `name` property. ### [`v0.16.8`](https://togithub.com/evanw/esbuild/releases/tag/v0.16.8) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.16.7...v0.16.8) - Allow plugins to resolve injected files ([#2754](https://togithub.com/evanw/esbuild/issues/2754)) Previously paths passed to the `inject` feature were always interpreted as file system paths. This meant that `onResolve` plugins would not be run for them and esbuild's default path resolver would always be used. This meant that the `inject` feature couldn't be used in the browser since the browser doesn't have access to a file system. This release runs paths passed to `inject` through esbuild's full path resolution pipeline so plugins now have a chance to handle them using `onResolve` callbacks. This makes it possible to write a plugin that makes esbuild's `inject` work in the browser. - Add the `empty` loader ([#1541](https://togithub.com/evanw/esbuild/issues/1541), [#2753](https://togithub.com/evanw/esbuild/issues/2753)) The new `empty` loader tells esbuild to pretend that a file is empty. So for example `--loader:.css=empty` effectively skips all imports of `.css` files in JavaScript so that they aren't included in the bundle, since `import "./some-empty-file"` in JavaScript doesn't bundle anything. You can also use the `empty` loader to remove asset references in CSS files. For example `--loader:.png=empty` causes esbuild to replace asset references such as `url(image.png)` with `url()` so that they are no longer included in the resulting style sheet. - Fix `</script>` and `</style>` escaping for non-default targets ([#2748](https://togithub.com/evanw/esbuild/issues/2748)) The change in version 0.16.0 to give control over `</script>` escaping via `--supported:inline-script=false` or `--supported:inline-script=true` accidentally broke automatic escaping of `</script>` when an explicit `target` setting is specified. This release restores the correct automatic escaping of `</script>` (which should not depend on what `target` is set to). - Enable the `exports` field with `NODE_PATHS` ([#2752](https://togithub.com/evanw/esbuild/issues/2752)) Node has a rarely-used feature where you can extend the set of directories that node searches for packages using the `NODE_PATHS` environment variable. While esbuild supports this too, previously it only supported the old `main` field path resolution but did not support the new `exports` field package resolution. This release makes the path resolution rules the same again for both `node_modules` directories and `NODE_PATHS` directories. </details> <details> <summary>grpc-ecosystem/grpc-gateway</summary> ### [`v2.15.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.15.0) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.14.0...v2.15.0) #### What's Changed - utilities: Add preallocate for encoded by [@sashamelentyev](https://togithub.com/sashamelentyev) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3024](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3024) - chore(logspam): allow_repeated_fields_in_body is deprecated by [@alexeagle](https://togithub.com/alexeagle) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3040](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3040) - Various fixes by [@johanbrandhorst](https://togithub.com/johanbrandhorst) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3083](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3083) - fix(docs): add protoc-gen-openapiv2 to tutorial by [@Fahmadi](https://togithub.com/Fahmadi) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3075](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3075) - fix: add check for repeated google.protobuf.Any type by [@veith](https://togithub.com/veith) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3080](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3080) - Fix field order in yaml generated OAS file by [@same-id](https://togithub.com/same-id) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3084](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3084) - fix: include json name to query param filter by [@ljmsc](https://togithub.com/ljmsc) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3072](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3072) - Make read_only work with references using AllOf by [@same-id](https://togithub.com/same-id) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3082](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3082) #### New Contributors - [@alexeagle](https://togithub.com/alexeagle) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3040](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3040) - [@Fahmadi](https://togithub.com/Fahmadi) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3075](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3075) - [@ljmsc](https://togithub.com/ljmsc) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3072](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3072) **Full Changelog**: https://github.com/grpc-ecosystem/grpc-gateway/compare/v2.14.0...v2.15.0 </details> <details> <summary>grpc-ecosystem/grpc-health-probe</summary> ### [`v0.4.15`](https://togithub.com/grpc-ecosystem/grpc-health-probe/releases/tag/v0.4.15) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-health-probe/compare/v0.4.14...v0.4.15) #### Changelog - [`569cac1`](https://togithub.com/grpc-ecosystem/grpc-health-probe/c </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/aspect-build/silo).  Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>

revert: revert: Use patch from @bazel_tools//tools/build_defs/repo:ut…

5bcf074

…ils.bzl bazel-contrib#1269

linzhp approved these changes Dec 31, 2022

View reviewed changes

linzhp merged commit ce5a762 into bazel-contrib:master Dec 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

revert: revert: Use `patch` from `@bazel_tools//tools/build_defs/repo` #1381

revert: revert: Use `patch` from `@bazel_tools//tools/build_defs/repo` #1381

tyler-french commented Nov 28, 2022

linzhp commented Nov 28, 2022

sluongng commented Nov 29, 2022

meteorcloudy commented Nov 29, 2022

tyler-french commented Nov 29, 2022

linzhp left a comment

dpoluyanov commented Jan 23, 2023

revert: revert: Use patch from @bazel_tools//tools/build_defs/repo #1381

revert: revert: Use patch from @bazel_tools//tools/build_defs/repo #1381

Conversation

tyler-french commented Nov 28, 2022

linzhp commented Nov 28, 2022

sluongng commented Nov 29, 2022

meteorcloudy commented Nov 29, 2022

tyler-french commented Nov 29, 2022

linzhp left a comment

Choose a reason for hiding this comment

dpoluyanov commented Jan 23, 2023

revert: revert: Use `patch` from `@bazel_tools//tools/build_defs/repo` #1381

revert: revert: Use `patch` from `@bazel_tools//tools/build_defs/repo` #1381