Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bazel incompatible changes #272

Closed
laurentlb opened this issue Jan 8, 2019 · 4 comments
Closed

Fix Bazel incompatible changes #272

laurentlb opened this issue Jan 8, 2019 · 4 comments
Assignees
@xingao267

Comments

@laurentlb
Copy link
Contributor

To make sure this repository continues working, we should make sure it's compatible with --all_incompatible_changes.

As a first step, I suggest trying with --incompatible_no_transitive_loads (as I plan to flip this flag soon).

Let me know if you need help (I didn't manage to test this repository without credentials).
@xingao267 xingao267 self-assigned this Jan 9, 2019
@xingao267
Copy link
Member

Fix in dependent repo: GoogleContainerTools/base-images-docker#274

@xingao267
Copy link
Member

Fix in dependent repo: bazelbuild/rules_docker#648

@xingao267
Copy link
Member

Fix in this repo: #274

@xingao267
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xingao267 xingao267

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laurentlb @xingao267