-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom skylark build flags in external dependencies #10039
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
Comments
gregestren
added
P2
We'll consider working on this in future. (Assignee optional)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
labels
Oct 15, 2019
This is worth at least clarifying which part of the code base is failing to make the connection. From there we can prioritize the right fix. |
PR to support Starlark-defined flags starting with |
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
Description of the problem / feature request:
The implementation of Skylark support for custom build flags
(#5577) does not work for custom build flags in external repositories.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Given the following setup:
the output looks like
I would expect the bottom two cases to work and output
//:myext.txt (null)
. The alias would be very convenient for the user to shorten the command line.What operating system are you running Bazel on?
Linux
What's the output of
bazel info release
?release 1.0.0
Have you found anything relevant by searching the web?
@gregestren suggested reporting this bug/feature request as the core functionality was implemented in #5577.
The text was updated successfully, but these errors were encountered: